[GitHub] [beam] lukecwik commented on a change in pull request #16263: [BEAM-13015] Migrate all user state and side input implementations to support caching.

[GitBox <gi...@apache.org>]

lukecwik commented on a change in pull request #16263:
URL: https://github.com/apache/beam/pull/16263#discussion_r778457940



##########
File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java
##########
@@ -738,7 +743,21 @@ private StateKey createBagUserStateKey(String stateId) {
     return builder.build();
   }
 
-  private StateKey createMultimapUserStateKey(String stateId) {
+  private <KeyT, ValueT> MultimapUserState<KeyT, ValueT> createMultimapUserState(
+      StateKey stateKey, Coder<KeyT> keyCoder, Coder<ValueT> valueCoder) {
+    MultimapUserState<KeyT, ValueT> rval =
+        new MultimapUserState(
+            Caches.noop(),

Review comment:
       There is another follow-up change that updates this to use the cache which will handle this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org