You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/04/08 10:47:45 UTC
[GitHub] [druid] adarshsanjeev opened a new pull request, #12414: Make error messages for insert statements consistent with select statements
adarshsanjeev opened a new pull request, #12414:
URL: https://github.com/apache/druid/pull/12414
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
<!-- Please read the doc for contribution (https://github.com/apache/druid/blob/master/CONTRIBUTING.md) before making this PR. Also, once you open a PR, please _avoid using force pushes and rebasing_ since these make it difficult for reviewers to see what you've changed in response to their reviews. See [the 'If your pull request shows conflicts with master' section](https://github.com/apache/druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master) for more details. -->
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
For a query like
`INSERT INTO tablename SELECT channel, added as count FROM wikipedia` the error message is `Encountered "as count"`. However, for the insert statement
`INSERT INTO t
SELECT
channel,
added as count
FROM wikipedia
PARTITIONED BY ALL`
returns `INSERT statements must specify PARTITIONED BY clause explictly` (incorrectly). This PR corrects this.
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
- Add EOF to end of Druid SQL Insert statements
- Rename SQL Insert statements in the parser to reflect the behaviour change
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [x] been self-reviewed.
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 commented on a diff in pull request #12414: Make error messages for insert statements consistent with select statements
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 commented on code in PR #12414:
URL: https://github.com/apache/druid/pull/12414#discussion_r846037205
##########
sql/src/main/codegen/includes/insert.ftl:
##########
@@ -34,7 +34,7 @@ SqlNode DruidSqlInsertEof() :
<CLUSTERED> <BY>
clusteredBy = ClusterItems()
]
- // EOF is also present in SqlStmtEof but is a special case and multiple occurances together are valid with one token
+ // EOF is also present in SqlStmtEof but EOF is a special case and a single EOF can be consumed multiple times. The reason for adding EOF here is to ensure that we create a DruidSqlInsert node after the syntax has been validated and throw SQL syntax errors before performing validations in the DruidSqlInsert which can overshadow the actual error message```
Review Comment:
can we break this to multi-line comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] LakshSingla commented on a diff in pull request #12414: Make error messages for insert statements consistent with select statements
Posted by GitBox <gi...@apache.org>.
LakshSingla commented on code in PR #12414:
URL: https://github.com/apache/druid/pull/12414#discussion_r846000668
##########
sql/src/main/codegen/includes/insert.ftl:
##########
@@ -34,6 +34,8 @@ SqlNode DruidSqlInsert() :
<CLUSTERED> <BY>
clusteredBy = ClusterItems()
]
+ // EOF is also present in SqlStmtEof but is a special case and multiple occurances together are valid with one token
Review Comment:
```suggestion
// EOF is also present in SqlStmtEof but EOF is a special case and a single EOF can be consumed multiple times. The reason for adding EOF here is to ensure that we create a DruidSqlInsert node after the syntax has been validated and throw SQL syntax errors before performing validations in the DruidSqlInsert which can overshadow the actual error message```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhishekagarwal87 merged pull request #12414: Make error messages for insert statements consistent with select statements
Posted by GitBox <gi...@apache.org>.
abhishekagarwal87 merged PR #12414:
URL: https://github.com/apache/druid/pull/12414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org