You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/08/10 17:02:10 UTC
[GitHub] [solr] markrmiller opened a new pull request #253: SOLR-15580: Allow setting the base work directory to another location…
markrmiller opened a new pull request #253:
URL: https://github.com/apache/solr/pull/253
Currently, you can specify an alternate location for a mini-cluster if it's created, but this is a kind of special case where that mini-cluster will not be removed or altered if specified this way. This allows creating something like a 150GB setup in some location and testing against it without have to recreate it each time.
It's also useful to be able to just relocate the work directory itself with no alteration in behaviors - in the case you want to use a partition with more disk space for instance.
Options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #253: SOLR-15580: Allow setting the base work directory to another location…
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #253:
URL: https://github.com/apache/solr/pull/253#discussion_r718864578
##########
File path: solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java
##########
@@ -180,31 +184,31 @@ public void metricsEnabled(boolean metricsEnabled) {
}
public void startMiniCluster(int nodeCount) {
- log("starting mini cluster at base directory: " + baseDir.toAbsolutePath());
+ log("starting mini cluster at base directory: " + miniClusterBaseDir.toAbsolutePath());
- if (!allowClusterReuse && Files.exists(baseDir)) {
+ if (!allowClusterReuse && Files.exists(miniClusterBaseDir)) {
log("mini cluster base directory exists, removing ...");
try {
- deleteDirectory(baseDir);
+ deleteDirectory(miniClusterBaseDir);
} catch (IOException e) {
throw new RuntimeException(e);
}
createCollectionAndIndex = true;
- } else if (Files.exists(baseDir)) {
+ } else if (Files.exists(miniClusterBaseDir)) {
createCollectionAndIndex = false;
deleteMiniCluster = false;
Review comment:
Is this value ever read?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #253: SOLR-15580: Allow setting the base work directory to another location…
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #253:
URL: https://github.com/apache/solr/pull/253#discussion_r718864578
##########
File path: solr/benchmark/src/java/org/apache/solr/bench/MiniClusterState.java
##########
@@ -180,31 +184,31 @@ public void metricsEnabled(boolean metricsEnabled) {
}
public void startMiniCluster(int nodeCount) {
- log("starting mini cluster at base directory: " + baseDir.toAbsolutePath());
+ log("starting mini cluster at base directory: " + miniClusterBaseDir.toAbsolutePath());
- if (!allowClusterReuse && Files.exists(baseDir)) {
+ if (!allowClusterReuse && Files.exists(miniClusterBaseDir)) {
log("mini cluster base directory exists, removing ...");
try {
- deleteDirectory(baseDir);
+ deleteDirectory(miniClusterBaseDir);
} catch (IOException e) {
throw new RuntimeException(e);
}
createCollectionAndIndex = true;
- } else if (Files.exists(baseDir)) {
+ } else if (Files.exists(miniClusterBaseDir)) {
createCollectionAndIndex = false;
deleteMiniCluster = false;
Review comment:
Is this value ever read?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] markrmiller commented on pull request #253: SOLR-15580: Allow setting the base work directory to another location…
Posted by GitBox <gi...@apache.org>.
markrmiller commented on pull request #253:
URL: https://github.com/apache/solr/pull/253#issuecomment-933945207
Some of this already made it in as part of the data gen dsl issue as I had been using it. I've merged into main and there is some minor cleanup and the README update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] markrmiller closed pull request #253: SOLR-15580: Allow setting the base work directory to another location…
Posted by GitBox <gi...@apache.org>.
markrmiller closed pull request #253:
URL: https://github.com/apache/solr/pull/253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org