[jira] [Commented] (NIFI-2194) AmbariReportingTask should cache metrics

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-2194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15379507#comment-15379507 ] 

ASF GitHub Bot commented on NIFI-2194:
--------------------------------------

GitHub user bbende opened a pull request:

    https://github.com/apache/nifi/pull/659

    NIFI-2194 Caching metrics in AmbariReportingTask so each iteration se…

    …nds last iteration's metrics

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bbende/nifi NIFI-2194

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/659.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #659
    
----
commit 9640a5bdc150c52e7866ceb42c86fe95b168565a
Author: Bryan Bende <bb...@apache.org>
Date:   2016-07-13T21:53:54Z

    NIFI-2194 Caching metrics in AmbariReportingTask so each iteration sends last iteration's metrics

----


> AmbariReportingTask should cache metrics
> ----------------------------------------
>
>                 Key: NIFI-2194
>                 URL: https://issues.apache.org/jira/browse/NIFI-2194
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 0.6.1
>            Reporter: Bryan Bende
>            Assignee: Bryan Bende
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> The Ambari Metrics Collector expects clients to perform some amount of caching/aggregation before sending metrics. This is typically done by using the TimelineMetricsCache provided in ambari-commons. The AmbariReportingTask should use this to properly send metrics.
> In addition many applications sending metrics extend AbstractTimelineMetricsSink [1]. It is not required to do so, but may be useful here.
> [1] https://github.com/apache/ambari/blob/trunk/ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)