[GitHub] [skywalking-satellite] EvanLjp commented on a change in pull request #11: add prometheus server

[GitBox <gi...@apache.org>]

EvanLjp commented on a change in pull request #11:
URL: https://github.com/apache/skywalking-satellite/pull/11#discussion_r549621857



##########
File path: configs/satellite_config.yaml
##########
@@ -17,23 +17,30 @@
 
 logger:
   log_pattern: "%time [%level][%field] - %msg"
-  time_pattern: "2006-01-02 15:04:05.001"
+  time_pattern: "2006-01-02 15:04:05.000"
   level: "info"
 
+telemetry:
+  namespace: namespaces
+  service: service1
+  instance: instance1
+
 sharing:
+  common_config:
+    pipe_name: sharing
   clients:
     - plugin_name: "grpc-client"
       k: v
   servers:
     - plugin_name: "grpc-server"
       k: v
-namespaces:
+pipes:

Review comment:
       the namespace concept is similar to the Kubernetes namespaces, so I change the original namespaces concept to the new name call pipe. Each pipe has one gatherer, one processor, and one sender.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org