You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/07/07 04:37:10 UTC

[GitHub] [bookkeeper] hangc0276 commented on a diff in pull request #3388: Remove meaningless useFallocate definition from DirectWriter

hangc0276 commented on code in PR #3388:
URL: https://github.com/apache/bookkeeper/pull/3388#discussion_r915450706


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/directentrylogger/DirectWriter.java:
##########
@@ -49,7 +49,6 @@ class DirectWriter implements LogWriter {
     final List<Future<?>> outstandingWrites = new ArrayList<Future<?>>();
     Buffer nativeBuffer;
     long offset;
-    private volatile boolean useFallocate = true;

Review Comment:
   It's better to use `static`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org