You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4cxx-dev@logging.apache.org by "Chand Priyankara (JIRA)" <lo...@logging.apache.org> on 2014/01/10 02:35:51 UTC
[jira] [Closed] (LOGCXX-419) 'typedef spi::KeySet KeySet' changes
meaning of typedef
[ https://issues.apache.org/jira/browse/LOGCXX-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chand Priyankara closed LOGCXX-419.
-----------------------------------
resolve is fine. agreed.
> 'typedef spi::KeySet KeySet' changes meaning of typedef
> -------------------------------------------------------
>
> Key: LOGCXX-419
> URL: https://issues.apache.org/jira/browse/LOGCXX-419
> Project: Log4cxx
> Issue Type: Bug
> Components: Filter
> Affects Versions: 0.10.0, 0.10.1
> Environment: Ubuntu Saucy, GCC 4.8.1, Autotools
> Reporter: Rhys Ulerich
> Assignee: Rhys Ulerich
>
> Observed in the build...
> In file included from ../../../../log4cxx/src/main/include/log4cxx/spi/filter.h:24:0,
> from ../../../../log4cxx/src/main/include/log4cxx/filter/andfilter.h:27,
> from ../../../../log4cxx/src/main/cpp/andfilter.cpp:18:
> ../../../../log4cxx/src/main/include/log4cxx/spi/loggingevent.h:171:45: error: declaration of ‘typedef log4cxx::spi::KeySet log4cxx::spi::LoggingEvent::KeySet’ [-fpermissive]
> typedef spi::KeySet KeySet;
> ^
> In file included from ../../../../log4cxx/src/main/include/log4cxx/helpers/objectptr.h:21:0,
> from ../../../../log4cxx/src/main/include/log4cxx/spi/filter.h:21,
> from ../../../../log4cxx/src/main/include/log4cxx/filter/andfilter.h:27,
> from ../../../../log4cxx/src/main/cpp/andfilter.cpp:18:
> ../../../../log4cxx/src/main/include/log4cxx/spi/loggingevent.h:46:34: error: changes meaning of ‘KeySet’ from ‘typedef class std::vector<std::basic_string<char> > log4cxx::spi::KeySet’ [-fpermissive]
> LOG4CXX_LIST_DEF(KeySet, LogString);
> ^
> ../../../../log4cxx/src/main/include/log4cxx/log4cxx.h:48:55: note: in definition of macro ‘LOG4CXX_LIST_DEF’
> #define LOG4CXX_LIST_DEF(N, T) typedef std::vector<T> N
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
Re: [jira] [Closed] (LOGCXX-419) 'typedef spi::KeySet KeySet' changes
meaning of typedef
Posted by Florian Seydoux <fs...@apache.org>.
On 10.01.2014 03:38, chand priyankara wrote:
> hey All,
>
> Is it OK that we close once verified? Or does it need any further steps
> before closing?
No idea of the common practice at ASF, but for me issues must be closed
by someone else than the resolver...
for compilation issue, soon as the issue is resolved for the specific
OS/compilation chain, and there is no regression on other OS (ideally
checked through the CI, but up to now it could just be a compilation
from another of us), then the issue can be closed.
for others bugs, I would usually expect a unit test (when possible), or
at least test code attached to the jira entry, verified by someone else.
I like to have the issue formally closed at the time the release is
prepared (stab. phase), which allows to properly tag them, and double
check with the change-log, but it's maybe too heavy for us.
flo
Re: [jira] [Closed] (LOGCXX-419) 'typedef spi::KeySet KeySet' changes
meaning of typedef
Posted by chand priyankara <ch...@engineering.com>.
hey All,
Is it OK that we close once verified? Or does it need any further steps
before closing?
regards,
*Chand Priyankara* [image: Facebook]<http://www.facebook.com/chand.priyankara>
[image: LinkedIn] <http://lk.linkedin.com/in/chandpriyankara> [image:
Blogger] <http://chandpriyankara.blogspot.com/> [image: Google
Plus]<http://plus.google.com/104246340732624023499>
|BSc(Eng) - Electrical & Information
|(094) 773-361-566
|chand@engineering.com
|http://chandpriyankara.blogspot.com
<http://www.iucnredlist.org/amazing-species>sent via internet
On Fri, Jan 10, 2014 at 7:05 AM, Chand Priyankara (JIRA) <
log4cxx-dev@logging.apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/LOGCXX-419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Chand Priyankara closed LOGCXX-419.
> -----------------------------------
>
>
> resolve is fine. agreed.
>
> > 'typedef spi::KeySet KeySet' changes meaning of typedef
> > -------------------------------------------------------
> >
> > Key: LOGCXX-419
> > URL: https://issues.apache.org/jira/browse/LOGCXX-419
> > Project: Log4cxx
> > Issue Type: Bug
> > Components: Filter
> > Affects Versions: 0.10.0, 0.10.1
> > Environment: Ubuntu Saucy, GCC 4.8.1, Autotools
> > Reporter: Rhys Ulerich
> > Assignee: Rhys Ulerich
> >
> > Observed in the build...
> > In file included from
> ../../../../log4cxx/src/main/include/log4cxx/spi/filter.h:24:0,
> > from
> ../../../../log4cxx/src/main/include/log4cxx/filter/andfilter.h:27,
> > from ../../../../log4cxx/src/main/cpp/andfilter.cpp:18:
> > ../../../../log4cxx/src/main/include/log4cxx/spi/loggingevent.h:171:45:
> error: declaration of ‘typedef log4cxx::spi::KeySet
> log4cxx::spi::LoggingEvent::KeySet’ [-fpermissive]
> > typedef spi::KeySet KeySet;
> > ^
> > In file included from
> ../../../../log4cxx/src/main/include/log4cxx/helpers/objectptr.h:21:0,
> > from
> ../../../../log4cxx/src/main/include/log4cxx/spi/filter.h:21,
> > from
> ../../../../log4cxx/src/main/include/log4cxx/filter/andfilter.h:27,
> > from ../../../../log4cxx/src/main/cpp/andfilter.cpp:18:
> > ../../../../log4cxx/src/main/include/log4cxx/spi/loggingevent.h:46:34:
> error: changes meaning of ‘KeySet’ from ‘typedef class
> std::vector<std::basic_string<char> > log4cxx::spi::KeySet’ [-fpermissive]
> > LOG4CXX_LIST_DEF(KeySet, LogString);
> > ^
> > ../../../../log4cxx/src/main/include/log4cxx/log4cxx.h:48:55: note: in
> definition of macro ‘LOG4CXX_LIST_DEF’
> > #define LOG4CXX_LIST_DEF(N, T) typedef std::vector<T> N
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.1.5#6160)
>