You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Shekharrajak (via GitHub)" <gi...@apache.org> on 2026/05/29 03:48:50 UTC
[PR] Flink 39789 avro local timestamp rel21 [flink]
Shekharrajak opened a new pull request, #28274:
URL: https://github.com/apache/flink/pull/28274
Fix [FLINK-39789](https://issues.apache.org/jira/browse/FLINK-39789).
## What is the purpose of the change
`AvroSchemaConverter.convertToDataType(String)` and `convertToTypeInfo(String)` — the only public Avro→Flink type-mapping entry points — silently dropped the logical type for `local-timestamp-millis` and `local-timestamp-micros` and returned `BIGINT` / `Long`, producing a Flink `RowType` that is incompatible with `TimestampData` at runtime.
The internal two-arg overloads contained branches for `local-timestamp-*`, but only on the `legacyTimestampMapping=false` arm. The single-arg public APIs hard-code `legacyTimestampMapping=true`, so those branches were unreachable from any public API.
## Brief change log
## Verifying this change
- `AvroSchemaConverter.convertToDataType(Schema, boolean)` — hoist `localTimestampMillis` / `localTimestampMicros` checks above the `legacyMapping` switch so they are honoured in both modes.
- `AvroSchemaConverter.convertToTypeInfo(Schema, boolean)` — identical hoist, mapping to `Types.LOCAL_DATE_TIME`.
- Add `AvroSchemaConverterLocalTimestampBehaviorTest` — 13 tests covering the single-arg public API, the two-arg overloads in both modes, the `convertToTypeInfo` mirror, the JIRA's exact runtime `ClassCastException` reproducer, and a round-trip sanity check.
- Update `AvroSchemaConverterTest.validateLegacyTimestampsSchema(...)` helpers — they previously hard-coded `Types.LONG` / `BIGINT` for `local_timestamp_*` (asserting the bug); now assert the spec-correct `Types.LOCAL_DATE_TIME` / `TIMESTAMP(p)`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change the checkbox below to `[X]` followed by the name of the tool, and uncomment the
"Generated-by" line. See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed. See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name and Version]
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39789] AvroSchemaConverter updates for local-timestamp-* and timestamp-nanos logical types [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #28274: [FLINK-39789] AvroSchemaConverter updates for local-timestamp-* and timestamp-nanos logical types
URL: https://github.com/apache/flink/pull/28274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Flink 39789 avro local timestamp rel21 [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #28274:
URL: https://github.com/apache/flink/pull/28274#issuecomment-4570346387
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "be77e45946a32344b5baf25a82f41dfe46932169",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "be77e45946a32344b5baf25a82f41dfe46932169",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* be77e45946a32344b5baf25a82f41dfe46932169 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39789] AvroSchemaConverter updates for local-timestamp-* and timestamp-nanos logical types [flink]
Posted by "Shekharrajak (via GitHub)" <gi...@apache.org>.
Shekharrajak commented on PR #28274:
URL: https://github.com/apache/flink/pull/28274#issuecomment-4576362638
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39789] AvroSchemaConverter updates for local-timestamp-* and timestamp-nanos logical types [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28274:
URL: https://github.com/apache/flink/pull/28274#issuecomment-5450820608
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-39789] AvroSchemaConverter updates for local-timestamp-* and timestamp-nanos logical types [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28274:
URL: https://github.com/apache/flink/pull/28274#issuecomment-5864997087
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org