You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/25 11:41:41 UTC

[GitHub] [arrow-rs] alamb commented on a change in pull request #569: Sort binary

alamb commented on a change in pull request #569:
URL: https://github.com/apache/arrow-rs/pull/569#discussion_r676132286



##########
File path: arrow/src/compute/kernels/sort.rs
##########
@@ -2375,6 +2494,179 @@ mod tests {
         );
     }
 
+    #[test]
+    fn test_sort_binary() {
+        test_sort_binary_arrays(

Review comment:
       May I suggest at least one test where the fixed size vector has a non zero value in index `0` or `1`? Like `vec[1, 0, 3]` or something to demonstrate that the entire array is being checked?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org