You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <de...@bloodhound.apache.org> on 2013/07/30 17:32:01 UTC
[Apache Bloodhound] #617: Switching from QCT to full dialogue loses
field values
#617: Switching from QCT to full dialogue loses field values
---------------------+---------------
Reporter: mudri | Owner:
Type: defect | Status: new
Priority: major | Version:
Resolution: |
---------------------+---------------
Anything written in the "Create Ticket" dropdown is lost when "More
fields" is clicked. The values in the fields should be posted through to
the /newticket page, but instead are discarded.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+----------------------
Reporter: mudri | Owner: gjm
Type: defect | Status: accepted
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords:
------------------------+----------------------
Changes (by gjm):
* owner: => gjm
* status: new => accepted
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:9>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+-----------------
Reporter: mudri | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords:
------------------------+-----------------
Changes (by gjm):
* status: needinfo(new) => new
* owner: antony =>
Comment:
Happy with the work so far. A few interesting aspects that might be
improved on are:
* modifying to deal with long free text fields (some browsers/webservers
may lose a very long querystring
* possibly dropping the {{{__FORM_TOKEN}}} and empty fields from the
solution
such enhancements can move to a new ticket though.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:8>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full dialogue
loses field values
Posted by James Wood <ja...@wandisco.com>.
On Tue, Jul 30, 2013 at 4:32 PM, Apache Bloodhound <
dev@bloodhound.apache.org> wrote:
> #617: Switching from QCT to full dialogue loses field values
> ---------------------+---------------
> Reporter: mudri | Owner:
> Type: defect | Status: new
> Priority: major | Version:
> Resolution: |
> ---------------------+---------------
> Anything written in the "Create Ticket" dropdown is lost when "More
> fields" is clicked. The values in the fields should be posted through to
> the /newticket page, but instead are discarded.
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/617>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound issue tracker
>
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values (was: Switching from QCT to full
dialogue loses field values)
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+--------------------
Reporter: mudri | Owner: nobody
Type: defect | Status: new
Priority: major | Milestone:
Component: dashboard | Version:
Resolution: | Keywords:
------------------------+--------------------
Changes (by mudri):
* owner: => nobody
* component: => dashboard
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+--------------------
Reporter: mudri | Owner: gjm
Type: defect | Status: closed
Priority: major | Milestone:
Component: ui design | Version:
Resolution: fixed | Keywords:
------------------------+--------------------
Changes (by gjm):
* status: accepted => closed
* resolution: => fixed
Comment:
r1550449 commits the patch from antony
Further work should continue in #727
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:10>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+---------------------------
Reporter: mudri | Owner: antony
Type: defect | Status: needinfo(new)
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords:
------------------------+---------------------------
Comment (by antony):
Please note [attachment:preserve_qct_fields_all.diff] does not appear to
work for
QCT forms outside main/products/some_chlid . I'm currently looking
into this.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+--------------------
Reporter: mudri | Owner: nobody
Type: defect | Status: new
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords:
------------------------+--------------------
Changes (by mudri):
* component: dashboard => ui design
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+--------------------
Reporter: mudri | Owner: nobody
Type: defect | Status: new
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords:
------------------------+--------------------
Comment (by rjollos):
One of the issues reported in #661 is a duplicate of this ticket.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create ticket
page loses field values
Posted by Gary Martin <ga...@wandisco.com>.
That would probably make the most sense at the moment. Thanks again for
your help in all this.
Cheers,
Gary
On 13/12/13 08:33, Antony Semonella wrote:
> Thanks, all, for the advice. I plan to look at #727 to re-implement
> the QCT field preservation using a POST as suggested.
> I think it'd be useful to write a "QCT field preservation" unit test
> for ProductTicketModule.process_request . I'm I right in thinking that
> the most appropriate location for this would be:
>
> bloodhound_multiproduct/tests/web_ui.py
>
> Cheers,
>
> Antony
>
> On 12 December 2013 19:44, Ryan Ollos <ry...@wandisco.com> wrote:
>> On Thu, Dec 12, 2013 at 9:14 AM, Antony Semonella <as...@gmail.com>wrote:
>>
>>> Thanks all,
>>>
>>> I'll have a look at updating this to use a POST request and writing a
>>> test around this.
>>>
>>> Cheers,
>>>
>>> Antony
>>
>> To explain Olemis' comment, the issue with writing a test is that the
>> current functional test suite uses Twill, which doesn't have support for
>> testing JavaScript. Eventually we might be able to migrate to a new testing
>> framework, but that seems like a fairly good-sized project to tackle. I
>> don't say that to discourage you from pursuing or discussing here further
>> though. It is just most likely the case that there a few steps needed to
>> introduce the ability to test JavaScript, such as selecting a testing
>> framework.
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Antony Semonella <as...@gmail.com>.
Thanks, all, for the advice. I plan to look at #727 to re-implement
the QCT field preservation using a POST as suggested.
I think it'd be useful to write a "QCT field preservation" unit test
for ProductTicketModule.process_request . I'm I right in thinking that
the most appropriate location for this would be:
bloodhound_multiproduct/tests/web_ui.py
Cheers,
Antony
On 12 December 2013 19:44, Ryan Ollos <ry...@wandisco.com> wrote:
> On Thu, Dec 12, 2013 at 9:14 AM, Antony Semonella <as...@gmail.com>wrote:
>
>> Thanks all,
>>
>> I'll have a look at updating this to use a POST request and writing a
>> test around this.
>>
>> Cheers,
>>
>> Antony
>
>
> To explain Olemis' comment, the issue with writing a test is that the
> current functional test suite uses Twill, which doesn't have support for
> testing JavaScript. Eventually we might be able to migrate to a new testing
> framework, but that seems like a fairly good-sized project to tackle. I
> don't say that to discourage you from pursuing or discussing here further
> though. It is just most likely the case that there a few steps needed to
> introduce the ability to test JavaScript, such as selecting a testing
> framework.
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Ryan Ollos <ry...@wandisco.com>.
On Thu, Dec 12, 2013 at 9:14 AM, Antony Semonella <as...@gmail.com>wrote:
> Thanks all,
>
> I'll have a look at updating this to use a POST request and writing a
> test around this.
>
> Cheers,
>
> Antony
To explain Olemis' comment, the issue with writing a test is that the
current functional test suite uses Twill, which doesn't have support for
testing JavaScript. Eventually we might be able to migrate to a new testing
framework, but that seems like a fairly good-sized project to tackle. I
don't say that to discourage you from pursuing or discussing here further
though. It is just most likely the case that there a few steps needed to
introduce the ability to test JavaScript, such as selecting a testing
framework.
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Antony Semonella <as...@gmail.com>.
Thanks all,
I'll have a look at updating this to use a POST request and writing a
test around this.
Cheers,
Antony
On 12 December 2013 17:11, Gary Martin <ga...@wandisco.com> wrote:
> On 12/12/13 16:17, Olemis Lang wrote:
>>
>> On Thu, Dec 12, 2013 at 11:05 AM, Gary Martin
>> <ga...@wandisco.com>wrote:
>>
>>> On 12/12/13 15:25, Olemis Lang wrote:
>>>
>>>> On Wed, Dec 11, 2013 at 8:33 AM, Gary Martin <gary.martin@wandisco.com
>>>>>
>>>>> wrote:
>>>>
>>>> [...]
>>>>
>>>> While we could resort to POSTing instead, I can see the reasoning
>>>> behind
>>>>>
>>>>> not doing that. Pragmatism would probably trump such reasoning though.
>>>>> I
>>>>> think other solutions would either limit the field sizes or warn of
>>>>> possible loss of data over some limit. Perhaps I have missed something
>>>>> though.
>>>>>
>>>>>
>>>>>
>>>> IMO let's use POST
>>>>
>>>>
>>> I think that is probably the correct answer too but I am tempted to
>>> commit
>>> the patch as is and let Antony continue with enhancements if he wishes. I
>>> am unaware of any regressions from his current approach so I think this
>>> is
>>> already much better behaviour.
>>>
>>>
>>
>> Yes , my intention was not to suggest that current solution should not be
>> committed . However at least in theory there are two aspects missing IMO
>>
>> 1. use POST
>> 2. testing
>> * though this one might be impossible *now* since js code is
>> involved
>>
>
> Fair point.. there could conceivably be tests. Anyway, I have committed the
> code - my only modifications at this point have been minor style changes.
>
> I've opened #727 for further work. If Antony is interested in continuing, he
> will, of course, be very welcome to!
>
> Cheers,
> Gary
Re: [Apache Bloodhound] #617: Switching from QCT to full create ticket
page loses field values
Posted by Gary Martin <ga...@wandisco.com>.
On 12/12/13 16:17, Olemis Lang wrote:
> On Thu, Dec 12, 2013 at 11:05 AM, Gary Martin <ga...@wandisco.com>wrote:
>
>> On 12/12/13 15:25, Olemis Lang wrote:
>>
>>> On Wed, Dec 11, 2013 at 8:33 AM, Gary Martin <gary.martin@wandisco.com
>>>> wrote:
>>> [...]
>>>
>>> While we could resort to POSTing instead, I can see the reasoning behind
>>>> not doing that. Pragmatism would probably trump such reasoning though. I
>>>> think other solutions would either limit the field sizes or warn of
>>>> possible loss of data over some limit. Perhaps I have missed something
>>>> though.
>>>>
>>>>
>>>>
>>> IMO let's use POST
>>>
>>>
>> I think that is probably the correct answer too but I am tempted to commit
>> the patch as is and let Antony continue with enhancements if he wishes. I
>> am unaware of any regressions from his current approach so I think this is
>> already much better behaviour.
>>
>>
>
> Yes , my intention was not to suggest that current solution should not be
> committed . However at least in theory there are two aspects missing IMO
>
> 1. use POST
> 2. testing
> * though this one might be impossible *now* since js code is involved
>
Fair point.. there could conceivably be tests. Anyway, I have committed
the code - my only modifications at this point have been minor style
changes.
I've opened #727 for further work. If Antony is interested in
continuing, he will, of course, be very welcome to!
Cheers,
Gary
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Olemis Lang <ol...@gmail.com>.
On Thu, Dec 12, 2013 at 11:05 AM, Gary Martin <ga...@wandisco.com>wrote:
> On 12/12/13 15:25, Olemis Lang wrote:
>
>> On Wed, Dec 11, 2013 at 8:33 AM, Gary Martin <gary.martin@wandisco.com
>> >wrote:
>> [...]
>>
>> While we could resort to POSTing instead, I can see the reasoning behind
>>> not doing that. Pragmatism would probably trump such reasoning though. I
>>> think other solutions would either limit the field sizes or warn of
>>> possible loss of data over some limit. Perhaps I have missed something
>>> though.
>>>
>>>
>>>
>> IMO let's use POST
>>
>>
> I think that is probably the correct answer too but I am tempted to commit
> the patch as is and let Antony continue with enhancements if he wishes. I
> am unaware of any regressions from his current approach so I think this is
> already much better behaviour.
>
>
Yes , my intention was not to suggest that current solution should not be
committed . However at least in theory there are two aspects missing IMO
1. use POST
2. testing
* though this one might be impossible *now* since js code is involved
--
Regards,
Olemis - @olemislc
Re: [Apache Bloodhound] #617: Switching from QCT to full create ticket
page loses field values
Posted by Gary Martin <ga...@wandisco.com>.
On 12/12/13 15:25, Olemis Lang wrote:
> On Wed, Dec 11, 2013 at 8:33 AM, Gary Martin <ga...@wandisco.com>wrote:
> [...]
>
>> While we could resort to POSTing instead, I can see the reasoning behind
>> not doing that. Pragmatism would probably trump such reasoning though. I
>> think other solutions would either limit the field sizes or warn of
>> possible loss of data over some limit. Perhaps I have missed something
>> though.
>>
>>
>
> IMO let's use POST
>
I think that is probably the correct answer too but I am tempted to
commit the patch as is and let Antony continue with enhancements if he
wishes. I am unaware of any regressions from his current approach so I
think this is already much better behaviour.
Cheers,
Gary
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Olemis Lang <ol...@gmail.com>.
On Wed, Dec 11, 2013 at 8:33 AM, Gary Martin <ga...@wandisco.com>wrote:
[...]
> While we could resort to POSTing instead, I can see the reasoning behind
> not doing that. Pragmatism would probably trump such reasoning though. I
> think other solutions would either limit the field sizes or warn of
> possible loss of data over some limit. Perhaps I have missed something
> though.
>
>
IMO let's use POST
--
Regards,
Olemis - @olemislc
Re: [Apache Bloodhound] #617: Switching from QCT to full create ticket
page loses field values
Posted by Gary Martin <ga...@wandisco.com>.
Yes, I am pretty happy with that though there may still be a few tweaks
to look at. I don't think that this is a huge reason to reject the patch
in its current form (potentially we can commit and continue to improve)
but we may want to consider what we want to do when users attempt to
include very long entries in free text fields, potentially testing the
limits of some browsers and webservers.
While we could resort to POSTing instead, I can see the reasoning behind
not doing that. Pragmatism would probably trump such reasoning though. I
think other solutions would either limit the field sizes or warn of
possible loss of data over some limit. Perhaps I have missed something
though.
Cheers,
Gary
On 11/12/13 11:42, Gary Martin wrote:
> I haven't tested it quite yet but if my quick skim of the patch is
> anything to go by, it is looking a lot closer to what I was hoping. To
> be fair this is not quite what the wording of the ticket description
> was suggesting but allowing for any fields that the form specifies at
> the time of clicking the #qct-more button should be the right way to go.
>
> And, yes, we do need to get the available choices for tickets updated
> on change of product but that aspect doesn't need to be covered by
> Antony's work. #618 may be a more appropriate ticket for that to come
> under.
>
> Anyway, I'll try out the patch now and see what actually happens!
>
> Cheers,
> Gary
>
>
> On 11/12/13 10:54, Antony Semonella wrote:
>> Thanks for the tips Ryan,
>>
>> I've created a patch so the "More fields" link functions with global
>> and product scope, hopefully we're
>> making a bit more progress :)
>>
>> https://issues.apache.org/bloodhound/attachment/ticket/617/preserve_qct_fields_scope.diff
>>
>> N.B. Functionality needs to be written to update product dependent
>> field values when a product
>> is changed in the QCT.
>>
>> Cheers,
>>
>> Antony
>>
>> On 11 December 2013 09:49, Apache Bloodhound
>> <de...@bloodhound.apache.org> wrote:
>>> #617: Switching from QCT to full create ticket page loses field values
>>> ------------------------+---------------------------
>>> Reporter: mudri | Owner: antony
>>> Type: defect | Status: needinfo(new)
>>> Priority: major | Milestone:
>>> Component: ui design | Version:
>>> Resolution: | Keywords:
>>> ------------------------+---------------------------
>>>
>>> Comment (by antony):
>>>
>>> "More fields" link functioning with global and product scope, see:
>>> [attachment:preserve_qct_fields_scope.diff]
>>>
>>> --
>>> Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:7>
>>> Apache Bloodhound <https://issues.apache.org/bloodhound/>
>>> The Apache Bloodhound issue tracker
>
Re: [Apache Bloodhound] #617: Switching from QCT to full create ticket
page loses field values
Posted by Gary Martin <ga...@wandisco.com>.
I haven't tested it quite yet but if my quick skim of the patch is
anything to go by, it is looking a lot closer to what I was hoping. To
be fair this is not quite what the wording of the ticket description was
suggesting but allowing for any fields that the form specifies at the
time of clicking the #qct-more button should be the right way to go.
And, yes, we do need to get the available choices for tickets updated on
change of product but that aspect doesn't need to be covered by Antony's
work. #618 may be a more appropriate ticket for that to come under.
Anyway, I'll try out the patch now and see what actually happens!
Cheers,
Gary
On 11/12/13 10:54, Antony Semonella wrote:
> Thanks for the tips Ryan,
>
> I've created a patch so the "More fields" link functions with global
> and product scope, hopefully we're
> making a bit more progress :)
>
> https://issues.apache.org/bloodhound/attachment/ticket/617/preserve_qct_fields_scope.diff
>
> N.B. Functionality needs to be written to update product dependent
> field values when a product
> is changed in the QCT.
>
> Cheers,
>
> Antony
>
> On 11 December 2013 09:49, Apache Bloodhound <de...@bloodhound.apache.org> wrote:
>> #617: Switching from QCT to full create ticket page loses field values
>> ------------------------+---------------------------
>> Reporter: mudri | Owner: antony
>> Type: defect | Status: needinfo(new)
>> Priority: major | Milestone:
>> Component: ui design | Version:
>> Resolution: | Keywords:
>> ------------------------+---------------------------
>>
>> Comment (by antony):
>>
>> "More fields" link functioning with global and product scope, see:
>> [attachment:preserve_qct_fields_scope.diff]
>>
>> --
>> Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:7>
>> Apache Bloodhound <https://issues.apache.org/bloodhound/>
>> The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Antony Semonella <as...@gmail.com>.
Thanks for the tips Ryan,
I've created a patch so the "More fields" link functions with global
and product scope, hopefully we're
making a bit more progress :)
https://issues.apache.org/bloodhound/attachment/ticket/617/preserve_qct_fields_scope.diff
N.B. Functionality needs to be written to update product dependent
field values when a product
is changed in the QCT.
Cheers,
Antony
On 11 December 2013 09:49, Apache Bloodhound <de...@bloodhound.apache.org> wrote:
> #617: Switching from QCT to full create ticket page loses field values
> ------------------------+---------------------------
> Reporter: mudri | Owner: antony
> Type: defect | Status: needinfo(new)
> Priority: major | Milestone:
> Component: ui design | Version:
> Resolution: | Keywords:
> ------------------------+---------------------------
>
> Comment (by antony):
>
> "More fields" link functioning with global and product scope, see:
> [attachment:preserve_qct_fields_scope.diff]
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:7>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+---------------------------
Reporter: mudri | Owner: antony
Type: defect | Status: needinfo(new)
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords:
------------------------+---------------------------
Comment (by antony):
"More fields" link functioning with global and product scope, see:
[attachment:preserve_qct_fields_scope.diff​]
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+---------------------------
Reporter: mudri | Owner: antony
Type: defect | Status: needinfo(new)
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords:
------------------------+---------------------------
Changes (by antony):
* status: new => needinfo(new)
* owner: nobody => antony
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+-----------------------
Reporter: mudri | Owner: antony
Type: defect | Status: closed
Priority: major | Milestone: Release 8
Component: ui design | Version:
Resolution: fixed | Keywords:
------------------------+-----------------------
Changes (by gjm):
* owner: gjm => antony
* milestone: => Release 8
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:11>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Ryan Ollos <ry...@wandisco.com>.
On Mon, Dec 9, 2013 at 12:55 AM, Antony Semonella <as...@gmail.com>wrote:
> Hello Ryan,
>
> Thanks for looking at this, I've added a new patch to deal with:
Thanks! More good progress.
> > * Forwarding the values of all select fields in the form
>
> See:
>
> https://issues.apache.org/bloodhound/attachment/ticket/617/preserve_qct_fields_all.diff
>
> I will look at point 2 next to ensure a ticket is created at the
> correct path according to the Product selection.
>
> As a note, the QCT form displays "Version" and "Type" fields when
> accessed from a page that is a child of /main/products/ but does not
> when accessed as a child of /main/x.
We tend to refer to these as "global scope" and "product scope", which are
good terms to keep in mind to aid discussion.
> I'm I correct in assuming this is
> correct behavior as "Version" and "Type" field values are product
> specific?
>
Yeah, I believe it is intended that "Version" and "Type" are only displayed
when at product scope. I vaguely remember a discussion in which it was
suggested that Version and Type should be displayed when at global scope,
but their values should update based on the currently selected product.
(Another good feature would be to disabled the fields when at global scope
until a product has been selected.) Therefore, it may be that Version and
Type aren't currently displayed when at global scope simply because the
necessarily-complex code hasn't been written yet. That can be dealt with
later though after we fix the more fundamental problems with the QCT.
> If so, is the "Product" field redundant on the QCT form when accessed
> from /main/products/x?
>
I think it is not redundant because one may want to create a ticket for
product2 when in the scope of product1. I'll plan to push my changes in
#304 today, which fixes some related issues:
https://issues.apache.org/bloodhound/ticket/304
There is an option `[ticket] quick_create_fields` which allows the
administrator to define the fields that are presented in the QCT form. With
that in mind, we'll need grab whatever fields are present in the form and
forward the values, meaning we won't be able to expect `field_type` and
`field_version` to be the only select fields in the form.
So as you can see it is fairly complex and there are a lot of little issues
to solve, but great work so far!
Please note preserve_qct_fields_all.diff does not appear to work for
> QCT forms outside main/products/some_chlid . I'm currently looking
> into this.
>
> Cheers,
>
> Antony
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Antony Semonella <as...@gmail.com>.
Hello Ryan,
Thanks for looking at this, I've added a new patch to deal with:
> * Forwarding the values of all select fields in the form
See:
https://issues.apache.org/bloodhound/attachment/ticket/617/preserve_qct_fields_all.diff
I will look at point 2 next to ensure a ticket is created at the
correct path according to the Product selection.
As a note, the QCT form displays "Version" and "Type" fields when
accessed from a page that is a child of /main/products/ but does not
when accessed as a child of /main/x. I'm I correct in assuming this is
correct behavior as "Version" and "Type" field values are product
specific?
If so, is the "Product" field redundant on the QCT form when accessed
from /main/products/x?
Please note preserve_qct_fields_all.diff does not appear to work for
QCT forms outside main/products/some_chlid . I'm currently looking
into this.
Cheers,
Antony
On 9 December 2013 06:56, Ryan Ollos <ry...@wandisco.com> wrote:
> On Sun, Dec 8, 2013 at 6:31 AM, Antony Semonella <as...@gmail.com>wrote:
>
>> Hello all,
>>
>> The following patch will fix #617:
>>
>>
>> https://issues.apache.org/bloodhound/attachment/ticket/617/preserve_qct_fields.diff
>>
>> Cheers,
>>
>> Antony
>
>
> It looks like a good start. I'll do some testing this morning,
>
> Two related issues we should consider fixing:
> * Forwarding the values of all select fields in the form
> * Most importantly, "More fields" should forward the currently selected
> product. See comment in (1).
>
> (1) http://markmail.org/message/5enlgw4jsdyhce6u
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Ryan Ollos <ry...@wandisco.com>.
On Sun, Dec 8, 2013 at 6:31 AM, Antony Semonella <as...@gmail.com>wrote:
> Hello all,
>
> The following patch will fix #617:
>
>
> https://issues.apache.org/bloodhound/attachment/ticket/617/preserve_qct_fields.diff
>
> Cheers,
>
> Antony
It looks like a good start. I'll do some testing this morning,
Two related issues we should consider fixing:
* Forwarding the values of all select fields in the form
* Most importantly, "More fields" should forward the currently selected
product. See comment in (1).
(1) http://markmail.org/message/5enlgw4jsdyhce6u
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Antony Semonella <as...@gmail.com>.
Hello all,
The following patch will fix #617:
https://issues.apache.org/bloodhound/attachment/ticket/617/preserve_qct_fields.diff
Cheers,
Antony
On 8 December 2013 14:29, Apache Bloodhound <de...@bloodhound.apache.org> wrote:
> #617: Switching from QCT to full create ticket page loses field values
> ------------------------+---------------------------
> Reporter: mudri | Owner: antony
> Type: defect | Status: needinfo(new)
> Priority: major | Milestone:
> Component: ui design | Version:
> Resolution: | Keywords:
> ------------------------+---------------------------
>
> Comment (by antony):
>
> The patch [attachment:preserve_qct_fields.diff] will preserve summary and
> description values when "More fields' is clicked.
>
> --
> Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:5>
> Apache Bloodhound <https://issues.apache.org/bloodhound/>
> The Apache Bloodhound issue tracker
Re: [Apache Bloodhound] #617: Switching from QCT to full create
ticket page loses field values
Posted by Apache Bloodhound <de...@bloodhound.apache.org>.
#617: Switching from QCT to full create ticket page loses field values
------------------------+---------------------------
Reporter: mudri | Owner: antony
Type: defect | Status: needinfo(new)
Priority: major | Milestone:
Component: ui design | Version:
Resolution: | Keywords:
------------------------+---------------------------
Comment (by antony):
The patch [attachment:preserve_qct_fields.diff] will preserve summary and
description values when "More fields' is clicked.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/617#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound issue tracker