You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:22:31 UTC

[GitHub] [tvm] AndrewZhaoLuo opened a new pull request #8282: Add metal to list of backends for TVMC

AndrewZhaoLuo opened a new pull request #8282:
URL: https://github.com/apache/tvm/pull/8282


   Need this to test benchmarking for https://github.com/apache/tvm/pull/8069


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] masahi merged pull request #8282: Add metal to list of backends for TVMC

Posted by GitBox <gi...@apache.org>.
masahi merged pull request #8282:
URL: https://github.com/apache/tvm/pull/8282


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #8282: Add metal to list of backends for TVMC

Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8282:
URL: https://github.com/apache/tvm/pull/8282#issuecomment-864252957


   > LGTM. But I agree with @leandron that it would be nice to have a test case for Metal.
   > 
   > > Does our CI even test metal backend? Let me ask aroud
   > 
   > Maybe I'm mistaking (please, someone correct me if I'm wrong), but as far as I know, we don't run metal backend tests in our CI. And also unfortunately we have only few tests on Metal. But in case if such test will exist, we could run it locally and check that we didn't break something by some new changes.
   > Also, we are locally working on extending CI for validation on different Apple devices, so in the future this functionality might be added to tvm repository and such tests for Metal will be executed in the CI.
   
   Thanks for the clarification, that’s really helpful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8282: Add metal to list of backends for TVMC

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo commented on pull request #8282:
URL: https://github.com/apache/tvm/pull/8282#issuecomment-864222756






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] AndrewZhaoLuo edited a comment on pull request #8282: Add metal to list of backends for TVMC

Posted by GitBox <gi...@apache.org>.
AndrewZhaoLuo edited a comment on pull request #8282:
URL: https://github.com/apache/tvm/pull/8282#issuecomment-864242573


   Does our CI even test metal backend? Let me ask aroud


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] leandron commented on pull request #8282: Add metal to list of backends for TVMC

Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8282:
URL: https://github.com/apache/tvm/pull/8282#issuecomment-864374485


   Thanks @echuraev @AndrewZhaoLuo!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org