You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2011/05/26 18:49:39 UTC

[Bug 6603] New: Make sa-learn handle an empty folder list correctly - Debian patch

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6603

             Bug #: 6603
           Summary: Make sa-learn handle an empty folder list correctly -
                    Debian patch
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Learner
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: Darxus@ChaosReigns.com
    Classification: Unclassified


Created attachment 4904
  --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4904
Debian patch to fix empty list handling in sa-learn

This has been in the Debian packaging for two years.

Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=491159

The change is just:

-  @targets = ('-') unless @targets;
+  @targets = ('-') unless @targets || $opt{folders};

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6603] [review] Make sa-learn handle an empty folder list correctly - Debian patch

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6603

Darxus <Da...@ChaosReigns.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Darxus <Da...@ChaosReigns.com> 2011-08-11 18:17:11 UTC ---
Already committed to target 3.4.  Got enough votes for 3.3 but nobody ever
committed it.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6603] [review] Make sa-learn handle an empty folder list correctly - Debian patch

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6603

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |3.4.0
  Status Whiteboard|                            |ready to commit

--- Comment #6 from Mark Martinec <Ma...@ijs.si> 2011-06-02 19:06:11 UTC ---
I don't mind one way or another - here is a +1 from me for 3.3.2
if someone wants to commit it, otherwise just close it as it is.
Not to forget setting the target accordingly - makes it easier
for later understanding.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6603] Make sa-learn handle an empty folder list correctly - Debian patch

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6603

--- Comment #1 from Darxus <Da...@ChaosReigns.com> 2011-05-26 16:50:06 UTC ---
Created attachment 4905
  --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4905
Patch to remove Debian patch from trunk

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6603] [review] Make sa-learn handle an empty folder list correctly - Debian patch

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6603

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4904|0                           |1
        is obsolete|                            |
   Attachment #4905|0                           |1
        is obsolete|                            |

--- Comment #2 from Kevin A. McGrail <km...@pccc.com> 2011-05-27 22:22:44 UTC ---
Created attachment 4909
  --> https://issues.apache.org/SpamAssassin/attachment.cgi?id=4909
Revised version of the patch removing debian files, changing Manifest and
series

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6603] [review] Make sa-learn handle an empty folder list correctly - Debian patch

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6603

Darxus <Da...@ChaosReigns.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Darxus@ChaosReigns.com
            Summary|Make sa-learn handle an     |[review] Make sa-learn
                   |empty folder list correctly |handle an empty folder list
                   |- Debian patch              |correctly - Debian patch

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6603] [review] Make sa-learn handle an empty folder list correctly - Debian patch

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6603

Henrik Krohns <he...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hege@hege.li

--- Comment #5 from Henrik Krohns <he...@hege.li> 2011-05-28 09:55:27 UTC ---
looks like trivial +1 to me

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6603] [review] Make sa-learn handle an empty folder list correctly - Debian patch

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6603

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #3 from Kevin A. McGrail <km...@pccc.com> 2011-05-27 22:24:10 UTC ---
Trivial patch.  Committing to trunk along with more debian fixes and MANIFEST
plus removal of debian patch file.

Recommending this for 3.3.2 as a trivial patch as well and I am +1.

Thanks to the debian team for pushing this upstream.

Sending        MANIFEST
Deleting       debian/patches/50_sa-learn_fix_empty_list_handling
Sending        debian/patches/series
Sending        sa-learn.raw
Transmitting file data ...
Committed revision 1128487.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6603] [review] Make sa-learn handle an empty folder list correctly - Debian patch

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6603

--- Comment #4 from Darxus <Da...@ChaosReigns.com> 2011-05-27 22:58:21 UTC ---
I don't think it's worth the teeth pulling to get two more votes for 3.3.2.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.