You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Mugdha Varadkar <mu...@freestoneinfotech.com> on 2017/05/04 13:30:58 UTC

Review Request 58989: AMBARI-20779 ADDENDUM Create Ranger KMS HDFS audit folder as part of install

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58989/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-20779
    https://issues.apache.org/jira/browse/AMBARI-20779


Repository: ambari


Description
-------

Addendum patch to change ordering of RANGER-KMS service for RU and EU. Need to upgrade RANGER-KMS service after HDFS upgrade, as if Audit to HDFS is set to true, WebHDFS RESTAPI tries to create audit directory in hadoop this will fail as HDFS service will not be started.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e111dbf 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 6230921 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 47a7094 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 18c0c15 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 19031a8 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 8cfaa52 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml f7192ae 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 5120740 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 358fb6e 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 368bbe2 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 80436bf 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml ad9ae33 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml c180b61 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml 3ceea8f 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml c3436b9 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml f3b1fa6 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 0470b7a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-upgrade-2.6.xml f923702 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml a74d085 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 35d3da2 


Diff: https://reviews.apache.org/r/58989/diff/1/


Testing
-------

Tested EU upgrade to stack 2.6


Thanks,

Mugdha Varadkar


Re: Review Request 58989: AMBARI-20779 ADDENDUM Create Ranger KMS HDFS audit folder as part of install

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58989/#review174045
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On May 5, 2017, 11:55 a.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58989/
> -----------------------------------------------------------
> 
> (Updated May 5, 2017, 11:55 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20779
>     https://issues.apache.org/jira/browse/AMBARI-20779
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Addendum patch to change ordering of RANGER-KMS service for RU and EU. Need to upgrade RANGER-KMS service after HDFS upgrade, as if Audit to HDFS is set to true, WebHDFS RESTAPI tries to create audit directory in HDFS this will fail RANGER-KMS restart task during upgrade as HDFS service will not be started.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e111dbf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 6230921 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 47a7094 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 18c0c15 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 5120740 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 358fb6e 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 368bbe2 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml c180b61 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml 3ceea8f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml c3436b9 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-upgrade-2.6.xml f923702 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml a74d085 
> 
> 
> Diff: https://reviews.apache.org/r/58989/diff/2/
> 
> 
> Testing
> -------
> 
> Tested EU upgrade to stack 2.6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>


Re: Review Request 58989: AMBARI-20779 ADDENDUM Create Ranger KMS HDFS audit folder as part of install

Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58989/
-----------------------------------------------------------

(Updated May 5, 2017, 11:55 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-20779
    https://issues.apache.org/jira/browse/AMBARI-20779


Repository: ambari


Description
-------

Addendum patch to change ordering of RANGER-KMS service for RU and EU. Need to upgrade RANGER-KMS service after HDFS upgrade, as if Audit to HDFS is set to true, WebHDFS RESTAPI tries to create audit directory in HDFS this will fail RANGER-KMS restart task during upgrade as HDFS service will not be started.


Diffs (updated)
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e111dbf 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 6230921 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 47a7094 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 18c0c15 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 5120740 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 358fb6e 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 368bbe2 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml c180b61 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml 3ceea8f 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml c3436b9 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-upgrade-2.6.xml f923702 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml a74d085 


Diff: https://reviews.apache.org/r/58989/diff/2/

Changes: https://reviews.apache.org/r/58989/diff/1-2/


Testing
-------

Tested EU upgrade to stack 2.6


Thanks,

Mugdha Varadkar


Re: Review Request 58989: AMBARI-20779 ADDENDUM Create Ranger KMS HDFS audit folder as part of install

Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.

> On May 4, 2017, 7:43 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
> > Line 344 (original)
> > <https://reviews.apache.org/r/58989/diff/1/?file=1708261#file1708261line344>
> >
> >     I thought Ranger had to be upgraded before HDFS due to the plugins.

Hi Alejandro,

In Ambari Ranger and Ranger Kms are two different services. 
Current Upgrade order is Zookeeper > Ranger > Ranger Kms > HDFS .... Due to changes in Ranger Kms service for creating directory in HDFS, need to upgrade Ranger Kms after HDFS as during EU all services are stopped Ranger Kms restart fails to create directory in HDFS.

I can skip the changes for RU since there is no stop task for services as in EU. So for RU the HDFS service will be up.


- Mugdha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58989/#review173947
-----------------------------------------------------------


On May 4, 2017, 1:36 p.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58989/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20779
>     https://issues.apache.org/jira/browse/AMBARI-20779
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Addendum patch to change ordering of RANGER-KMS service for RU and EU. Need to upgrade RANGER-KMS service after HDFS upgrade, as if Audit to HDFS is set to true, WebHDFS RESTAPI tries to create audit directory in HDFS this will fail RANGER-KMS restart task during upgrade as HDFS service will not be started.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e111dbf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 6230921 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 47a7094 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 18c0c15 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 19031a8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 8cfaa52 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml f7192ae 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 5120740 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 358fb6e 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 368bbe2 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 80436bf 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml ad9ae33 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml c180b61 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml 3ceea8f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml c3436b9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml f3b1fa6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 0470b7a 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-upgrade-2.6.xml f923702 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml a74d085 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 35d3da2 
> 
> 
> Diff: https://reviews.apache.org/r/58989/diff/1/
> 
> 
> Testing
> -------
> 
> Tested EU upgrade to stack 2.6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>


Re: Review Request 58989: AMBARI-20779 ADDENDUM Create Ranger KMS HDFS audit folder as part of install

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58989/#review173947
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
Line 344 (original)
<https://reviews.apache.org/r/58989/#comment247017>

    I thought Ranger had to be upgraded before HDFS due to the plugins.


- Alejandro Fernandez


On May 4, 2017, 1:36 p.m., Mugdha Varadkar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58989/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-20779
>     https://issues.apache.org/jira/browse/AMBARI-20779
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Addendum patch to change ordering of RANGER-KMS service for RU and EU. Need to upgrade RANGER-KMS service after HDFS upgrade, as if Audit to HDFS is set to true, WebHDFS RESTAPI tries to create audit directory in HDFS this will fail RANGER-KMS restart task during upgrade as HDFS service will not be started.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e111dbf 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 6230921 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 47a7094 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 18c0c15 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 19031a8 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 8cfaa52 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml f7192ae 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 5120740 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 358fb6e 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 368bbe2 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 80436bf 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml ad9ae33 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml c180b61 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml 3ceea8f 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml c3436b9 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml f3b1fa6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 0470b7a 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-upgrade-2.6.xml f923702 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml a74d085 
>   ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 35d3da2 
> 
> 
> Diff: https://reviews.apache.org/r/58989/diff/1/
> 
> 
> Testing
> -------
> 
> Tested EU upgrade to stack 2.6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>


Re: Review Request 58989: AMBARI-20779 ADDENDUM Create Ranger KMS HDFS audit folder as part of install

Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58989/
-----------------------------------------------------------

(Updated May 4, 2017, 1:36 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Sumit Mohanty, and Velmurugan Periasamy.


Bugs: AMBARI-20779
    https://issues.apache.org/jira/browse/AMBARI-20779


Repository: ambari


Description (updated)
-------

Addendum patch to change ordering of RANGER-KMS service for RU and EU. Need to upgrade RANGER-KMS service after HDFS upgrade, as if Audit to HDFS is set to true, WebHDFS RESTAPI tries to create audit directory in HDFS this will fail RANGER-KMS restart task during upgrade as HDFS service will not be started.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml e111dbf 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 6230921 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 47a7094 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml 18c0c15 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 19031a8 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 8cfaa52 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml f7192ae 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.6.xml d98bb53 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml 5120740 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 358fb6e 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml 368bbe2 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 80436bf 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml ad9ae33 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.6.xml 1eb9836 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-upgrade-2.5.xml c180b61 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml 3ceea8f 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml c3436b9 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml f3b1fa6 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 0470b7a 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/host-upgrade-2.6.xml f923702 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml a74d085 
  ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/upgrade-2.6.xml 35d3da2 


Diff: https://reviews.apache.org/r/58989/diff/1/


Testing
-------

Tested EU upgrade to stack 2.6


Thanks,

Mugdha Varadkar