You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/06/03 07:42:43 UTC

[GitHub] [hudi] bvaradar opened a new pull request #1701: [HUDI-990] Timeline API : filterCompletedAndCompactionInstants needs to handle requested state correctly

bvaradar opened a new pull request #1701:
URL: https://github.com/apache/hudi/pull/1701


   Contains:
   
   1. Code changes to fix HUDI-990 and
   2. Fallback for remote file-system view disabled for tests. Unit tests have been made to fail when they cannot get response from remote file system view calls.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] bvaradar closed pull request #1701: [HUDI-990] Timeline API : filterCompletedAndCompactionInstants needs to handle requested state correctly

Posted by GitBox <gi...@apache.org>.
bvaradar closed pull request #1701:
URL: https://github.com/apache/hudi/pull/1701


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] codecov-commenter commented on pull request #1701: [HUDI-990] Timeline API : filterCompletedAndCompactionInstants needs to handle requested state correctly

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1701:
URL: https://github.com/apache/hudi/pull/1701#issuecomment-638466637


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=h1) Report
   > Merging [#1701](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=desc) into [release-0.5.3](https://codecov.io/gh/apache/hudi/commit/5fcc461647e197e805836c6aea24e9df8c09cf0f&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/1701/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=tree)
   
   ```diff
   @@                 Coverage Diff                 @@
   ##             release-0.5.3    #1701      +/-   ##
   ===================================================
   - Coverage            69.87%   69.80%   -0.08%     
   + Complexity             993      204     -789     
   ===================================================
     Files                  322      322              
     Lines                15514    15521       +7     
     Branches              1602     1603       +1     
   ===================================================
   - Hits                 10841    10834       -7     
   - Misses                3958     3972      +14     
     Partials               715      715              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../hudi/client/embedded/EmbeddedTimelineService.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2VtYmVkZGVkL0VtYmVkZGVkVGltZWxpbmVTZXJ2aWNlLmphdmE=) | `75.00% <100.00%> (+0.71%)` | `0.00 <0.00> (-7.00)` | :arrow_up: |
   | [.../org/apache/hudi/table/HoodieCopyOnWriteTable.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllQ29weU9uV3JpdGVUYWJsZS5qYXZh) | `90.71% <100.00%> (+0.02%)` | `0.00 <0.00> (-9.00)` | :arrow_up: |
   | [.../org/apache/hudi/table/HoodieMergeOnReadTable.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllTWVyZ2VPblJlYWRUYWJsZS5qYXZh) | `85.71% <100.00%> (+0.08%)` | `0.00 <0.00> (ø)` | |
   | [...i/common/table/timeline/HoodieDefaultTimeline.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL0hvb2RpZURlZmF1bHRUaW1lbGluZS5qYXZh) | `92.18% <100.00%> (ø)` | `0.00 <0.00> (-29.00)` | |
   | [...common/table/view/FileSystemViewStorageConfig.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvRmlsZVN5c3RlbVZpZXdTdG9yYWdlQ29uZmlnLmphdmE=) | `85.07% <100.00%> (+0.94%)` | `0.00 <0.00> (-8.00)` | :arrow_up: |
   | [...g/apache/hudi/exception/HoodieRemoteException.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0hvb2RpZVJlbW90ZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...on/table/view/RemoteHoodieTableFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvUmVtb3RlSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `77.59% <0.00%> (-5.47%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...e/hudi/timeline/service/FileSystemViewHandler.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvRmlsZVN5c3RlbVZpZXdIYW5kbGVyLmphdmE=) | `89.20% <0.00%> (-2.35%)` | `0.00% <0.00%> (-11.00%)` | |
   | [.../hudi/common/table/view/FileSystemViewManager.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvRmlsZVN5c3RlbVZpZXdNYW5hZ2VyLmphdmE=) | `84.48% <0.00%> (+3.44%)` | `0.00% <0.00%> (-13.00%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/common/model/HoodieKey.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUtleS5qYXZh) | `94.44% <0.00%> (+5.55%)` | `0.00% <0.00%> (-4.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=footer). Last update [5fcc461...a564522](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] bvaradar commented on pull request #1701: [HUDI-990] Timeline API : filterCompletedAndCompactionInstants needs to handle requested state correctly

Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1701:
URL: https://github.com/apache/hudi/pull/1701#issuecomment-638990096


   @nsivabalan : You can use 2 master commits mentioned in the link below to pull in this change.
   
    https://issues.apache.org/jira/browse/HUDI-890?focusedCommentId=17126054&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17126054
   
   I will close this PR as it is against the release branch and does not contain both  commits
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] codecov-commenter edited a comment on pull request #1701: [HUDI-990] Timeline API : filterCompletedAndCompactionInstants needs to handle requested state correctly

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1701:
URL: https://github.com/apache/hudi/pull/1701#issuecomment-638466637


   # [Codecov](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=h1) Report
   > Merging [#1701](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=desc) into [release-0.5.3](https://codecov.io/gh/apache/hudi/commit/5fcc461647e197e805836c6aea24e9df8c09cf0f&el=desc) will **decrease** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/hudi/pull/1701/graphs/tree.svg?width=650&height=150&src=pr&token=VTTXabwbs2)](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=tree)
   
   ```diff
   @@                 Coverage Diff                 @@
   ##             release-0.5.3    #1701      +/-   ##
   ===================================================
   - Coverage            69.87%   69.80%   -0.08%     
   + Complexity             993      204     -789     
   ===================================================
     Files                  322      322              
     Lines                15514    15521       +7     
     Branches              1602     1603       +1     
   ===================================================
   - Hits                 10841    10834       -7     
   - Misses                3958     3972      +14     
     Partials               715      715              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../hudi/client/embedded/EmbeddedTimelineService.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY2xpZW50L2VtYmVkZGVkL0VtYmVkZGVkVGltZWxpbmVTZXJ2aWNlLmphdmE=) | `75.00% <100.00%> (+0.71%)` | `0.00 <0.00> (-7.00)` | :arrow_up: |
   | [.../org/apache/hudi/table/HoodieCopyOnWriteTable.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllQ29weU9uV3JpdGVUYWJsZS5qYXZh) | `90.71% <100.00%> (+0.02%)` | `0.00 <0.00> (-9.00)` | :arrow_up: |
   | [.../org/apache/hudi/table/HoodieMergeOnReadTable.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdGFibGUvSG9vZGllTWVyZ2VPblJlYWRUYWJsZS5qYXZh) | `85.71% <100.00%> (+0.08%)` | `0.00 <0.00> (ø)` | |
   | [...i/common/table/timeline/HoodieDefaultTimeline.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3RpbWVsaW5lL0hvb2RpZURlZmF1bHRUaW1lbGluZS5qYXZh) | `92.18% <100.00%> (ø)` | `0.00 <0.00> (-29.00)` | |
   | [...common/table/view/FileSystemViewStorageConfig.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvRmlsZVN5c3RlbVZpZXdTdG9yYWdlQ29uZmlnLmphdmE=) | `85.07% <100.00%> (+0.94%)` | `0.00 <0.00> (-8.00)` | :arrow_up: |
   | [...g/apache/hudi/exception/HoodieRemoteException.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvZXhjZXB0aW9uL0hvb2RpZVJlbW90ZUV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
   | [...on/table/view/RemoteHoodieTableFileSystemView.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvUmVtb3RlSG9vZGllVGFibGVGaWxlU3lzdGVtVmlldy5qYXZh) | `77.59% <0.00%> (-5.47%)` | `0.00% <0.00%> (-6.00%)` | |
   | [...e/hudi/timeline/service/FileSystemViewHandler.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS10aW1lbGluZS1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9odWRpL3RpbWVsaW5lL3NlcnZpY2UvRmlsZVN5c3RlbVZpZXdIYW5kbGVyLmphdmE=) | `89.20% <0.00%> (-2.35%)` | `0.00% <0.00%> (-11.00%)` | |
   | [.../hudi/common/table/view/FileSystemViewManager.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL3RhYmxlL3ZpZXcvRmlsZVN5c3RlbVZpZXdNYW5hZ2VyLmphdmE=) | `84.48% <0.00%> (+3.44%)` | `0.00% <0.00%> (-13.00%)` | :arrow_up: |
   | [...n/java/org/apache/hudi/common/model/HoodieKey.java](https://codecov.io/gh/apache/hudi/pull/1701/diff?src=pr&el=tree#diff-aHVkaS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29tbW9uL21vZGVsL0hvb2RpZUtleS5qYXZh) | `94.44% <0.00%> (+5.55%)` | `0.00% <0.00%> (-4.00%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=footer). Last update [5fcc461...a564522](https://codecov.io/gh/apache/hudi/pull/1701?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hudi] bvaradar commented on pull request #1701: [HUDI-990] Timeline API : filterCompletedAndCompactionInstants needs to handle requested state correctly

Posted by GitBox <gi...@apache.org>.
bvaradar commented on pull request #1701:
URL: https://github.com/apache/hudi/pull/1701#issuecomment-638023012


   cc @vinothchandar @nsivabalan 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org