You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/03/30 08:19:33 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a change in pull request #8719: [Improvement-7697][Master/Worker] Change the task ack to runnning callback

caishunfeng commented on a change in pull request #8719:
URL: https://github.com/apache/dolphinscheduler/pull/8719#discussion_r838251499



##########
File path: dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/Event.java
##########
@@ -18,6 +18,9 @@
 package org.apache.dolphinscheduler.common.enums;
 
 public enum Event {
-    ACK,
-    RESULT;
+    DISPATCH,
+    DELAY,
+    RUNNING,
+    RESULT,

Review comment:
       > The last ',' is unnecessary.
   
   I think it's OK and next time can add enum type directly, do not need to handle `;`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org