You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/27 14:09:43 UTC

[GitHub] [incubator-tvm] lhutton1 opened a new pull request #5681: [RELAY] Fix segfault in pretty print when ObjectRef is null

lhutton1 opened a new pull request #5681:
URL: https://github.com/apache/incubator-tvm/pull/5681


   Encountered when pretty printing module with function attribute equal to NullValue<ObjectRef>().
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #5681: [RELAY] Fix segfault in pretty print when ObjectRef is null

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5681:
URL: https://github.com/apache/incubator-tvm/pull/5681


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5681: [RELAY] Fix segfault in pretty print when ObjectRef is null

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5681:
URL: https://github.com/apache/incubator-tvm/pull/5681#issuecomment-635592715


   we can create a new file tests/relay/test_text_printer.py


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5681: [RELAY] Fix segfault in pretty print when ObjectRef is null

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5681:
URL: https://github.com/apache/incubator-tvm/pull/5681#issuecomment-634761848


   Thanks @lhutton1 . please add a regression testcase to cover the issue as per https://tvm.apache.org/docs/contribute/code_review.html#ensure-test-coverage


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5681: [RELAY] Fix segfault in pretty print when ObjectRef is null

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #5681:
URL: https://github.com/apache/incubator-tvm/pull/5681#issuecomment-635592715


   https://github.com/apache/incubator-tvm/blob/master/tests/python/relay/test_ir_text_printer.py


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5681: [RELAY] Fix segfault in pretty print when ObjectRef is null

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5681:
URL: https://github.com/apache/incubator-tvm/pull/5681#issuecomment-636016677


   Thanks @lhutton1 !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org