You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/11 07:37:50 UTC
[GitHub] [hudi] gengxuhan opened a new pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
gengxuhan opened a new pull request #3453:
URL: https://github.com/apache/hudi/pull/3453
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61b15cdb659a4dc3de661ffc21f21416e545c37f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#discussion_r686592278
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("When there is a delay in file system metadata, you can choose to enable this configuration.");
+
+ public static final ConfigOption<Integer> INITIAL_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.initial_interval_ms")
+ .intType()
+ .defaultValue(400)
+ .withDescription("Amount of time (in ms) to wait, before checking for consistency after an operation on storage.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_interval_ms")
+ .intType()
+ .defaultValue(20000)
+ .withDescription("Maximum amount of time (in ms), to wait for consistency checking.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECKS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_checks")
Review comment:
ditto
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
Review comment:
Can we use shorter name for flink options: consistency.check.enabled
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("When there is a delay in file system metadata, you can choose to enable this configuration.");
+
+ public static final ConfigOption<Integer> INITIAL_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.initial_interval_ms")
+ .intType()
+ .defaultValue(400)
+ .withDescription("Amount of time (in ms) to wait, before checking for consistency after an operation on storage.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_interval_ms")
Review comment:
ditto
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("When there is a delay in file system metadata, you can choose to enable this configuration.");
+
+ public static final ConfigOption<Integer> INITIAL_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.initial_interval_ms")
+ .intType()
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] gengxuhan commented on a change in pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
gengxuhan commented on a change in pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#discussion_r686612609
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("When there is a delay in file system metadata, you can choose to enable this configuration.");
+
+ public static final ConfigOption<Integer> INITIAL_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.initial_interval_ms")
+ .intType()
+ .defaultValue(400)
+ .withDescription("Amount of time (in ms) to wait, before checking for consistency after an operation on storage.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_interval_ms")
+ .intType()
+ .defaultValue(20000)
+ .withDescription("Maximum amount of time (in ms), to wait for consistency checking.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECKS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_checks")
Review comment:
Hello, I revised it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-961588131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673",
"triggerID" : "897286723",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-961588131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673",
"triggerID" : "897286723",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] gengxuhan commented on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
gengxuhan commented on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-897377051
@danny0405 hi , Can this PR be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673",
"triggerID" : "897286723",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#discussion_r687561375
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -392,7 +392,7 @@ public HoodieInstant revertReplaceCommitInflightToRequested(HoodieInstant inflig
}
private void transitionState(HoodieInstant fromInstant, HoodieInstant toInstant, Option<byte[]> data) {
- transitionState(fromInstant, toInstant, data, false);
+ transitionState(fromInstant, toInstant, data, this.metaClient.getConsistencyGuardConfig().isConsistencyCheckEnabled());
}
Review comment:
Can you explain why the consistency check enabled then allows the duplicate files ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673",
"triggerID" : "897286723",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673",
"triggerID" : "897286723",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-961588131
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673",
"triggerID" : "897286723",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61b15cdb659a4dc3de661ffc21f21416e545c37f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647)
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] gengxuhan commented on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
gengxuhan commented on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-897286723
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] gengxuhan commented on a change in pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
gengxuhan commented on a change in pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#discussion_r686602054
##########
File path: hudi-flink/src/main/java/org/apache/hudi/configuration/FlinkOptions.java
##########
@@ -593,6 +593,30 @@ private FlinkOptions() {
.withDescription("INT64 with original type TIMESTAMP_MICROS is converted to hive timestamp type.\n"
+ "Disabled by default for backward compatibility.");
+ public static final ConfigOption<Boolean> CONSISTENCY_CHECK_ENABLED_PROP = ConfigOptions
+ .key("hoodie.consistency.check.enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription("When there is a delay in file system metadata, you can choose to enable this configuration.");
+
+ public static final ConfigOption<Integer> INITIAL_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.initial_interval_ms")
+ .intType()
+ .defaultValue(400)
+ .withDescription("Amount of time (in ms) to wait, before checking for consistency after an operation on storage.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECK_INTERVAL_MS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_interval_ms")
+ .intType()
+ .defaultValue(20000)
+ .withDescription("Maximum amount of time (in ms), to wait for consistency checking.");
+
+ public static final ConfigOption<Integer> MAX_CONSISTENCY_CHECKS_PROP = ConfigOptions
+ .key("hoodie.consistency.check.max_checks")
Review comment:
OK, I'll modify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] gengxuhan commented on a change in pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
gengxuhan commented on a change in pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#discussion_r687623533
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieActiveTimeline.java
##########
@@ -392,7 +392,7 @@ public HoodieInstant revertReplaceCommitInflightToRequested(HoodieInstant inflig
}
private void transitionState(HoodieInstant fromInstant, HoodieInstant toInstant, Option<byte[]> data) {
- transitionState(fromInstant, toInstant, data, false);
+ transitionState(fromInstant, toInstant, data, this.metaClient.getConsistencyGuardConfig().isConsistencyCheckEnabled());
}
Review comment:
@danny0405 Because in the HoodieWrapperFileSystem file system, only createNewFile uses consistencyguard,
If not called, it will not take effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61b15cdb659a4dc3de661ffc21f21416e545c37f Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647)
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61b15cdb659a4dc3de661ffc21f21416e545c37f Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647)
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673",
"triggerID" : "897286723",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 61b15cdb659a4dc3de661ffc21f21416e545c37f UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] gengxuhan commented on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
gengxuhan commented on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896586187
flink support ConsistencyGuard plugin,When there is metadata latency in the file system,Submit CKP once, and then start a new instant. Because the commit cannot be seen, the data will be rolled back. @leesf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #3453: [HUDI-2296] pr flink support ConsistencyGuard plugin
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3453:
URL: https://github.com/apache/hudi/pull/3453#issuecomment-896577196
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1647",
"triggerID" : "61b15cdb659a4dc3de661ffc21f21416e545c37f",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653",
"triggerID" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"triggerType" : "PUSH"
}, {
"hash" : "81879b0fd4dfe9b5c8c009405de648eb18b426f9",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673",
"triggerID" : "897286723",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 81879b0fd4dfe9b5c8c009405de648eb18b426f9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1653) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1673)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org