You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/07/20 19:32:00 UTC

[GitHub] [incubator-devlake] keon94 commented on a diff in pull request #2557: fix: running gitextractor as a standalone process

keon94 commented on code in PR #2557:
URL: https://github.com/apache/incubator-devlake/pull/2557#discussion_r925983831


##########
plugins/gitextractor/main.go:
##########
@@ -74,7 +74,7 @@ func main() {
 		"git extractor",
 		nil,
 	)
-	repo, err := newGitRepo(subTaskCtx.TaskContext(), storage, tasks.GitExtractorOptions{

Review Comment:
   another (and simpler) solution is to just pass the subtaskCtx directly here, and change the TaskContext variables/signatures in gitextractor.go and repo_creator.go to be ExecContext instead (due to polymorphism). I just tested that and it works.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org