[GitHub] [couchdb] nickva commented on issue #3948: badarg error in couch_util:reorder_results from fabric doc_update

[GitBox <gi...@apache.org>]

nickva commented on issue #3948:
URL: https://github.com/apache/couchdb/issues/3948#issuecomment-1069187996


   @tonysun83 yeah, we could mimic the `couch_util:get_value(Key, SortedResults)` => `undefined` for missing entries, but I wonder if we should double-check how we end up in this state.
   
   I could see ending up here if we hit a `timeout` error but it looks like we end up there from the first clause in: https://github.com/apache/couchdb/blob/e4b8a4624fc7ae09b4649aac9a8d68226208cd8b/src/fabric/src/fabric_doc_update.erl#L41-L45
   
   `ok | accepted | error` so guessing would it's probably `error`? Or is it because we got a bunch of `rexi_DOWN` or `rexi_EXIT` and called `skip_message` https://github.com/apache/couchdb/blob/e4b8a4624fc7ae09b4649aac9a8d68226208cd8b/src/fabric/src/fabric_doc_update.erl#L62-L74?
   
   In general for `undefined`, we should probably emit a `missing_response` or `internal_server_error`. It's interesting what our guarantees are with respect to what return code we emit then, should it be a 201/202 even if we didn't get any results for some docs...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org