[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7751: extend a bit on the FileUploadDownloadClient

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on a change in pull request #7751:
URL: https://github.com/apache/pinot/pull/7751#discussion_r747840163



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/FileUploadDownloadClient.java
##########
@@ -578,6 +578,18 @@ public SimpleHttpResponse sendDeleteRequest(URI uri, String authToken)
     return sendRequest(requestBuilder.build());
   }
 
+  public SimpleHttpResponse postJsonRequest(URI uri, String jsonRequestBody, String authToken)

Review comment:
       Annotate `jsonRequestBody` as nullable.
   
   Side question: Could `authToken` be null? Will it work properly when it is null?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org