[GitHub] [incubator-druid] himanshug commented on a change in pull request #7716: AggregatorUtil should cache parsed expression to avoid memory problem (OOM/FGC) when Expression is used in metricsSpec

[GitBox <gi...@apache.org>]

himanshug commented on a change in pull request #7716: AggregatorUtil should cache parsed expression to avoid memory problem (OOM/FGC) when Expression is used in metricsSpec
URL: https://github.com/apache/incubator-druid/pull/7716#discussion_r286188705
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/math/expr/Parser.java
 ##########
 @@ -75,6 +75,9 @@ public static Expr parse(String in, ExprMacroTable macroTable)
   @VisibleForTesting
   static Expr parse(String in, ExprMacroTable macroTable, boolean withFlatten)
   {
+    if (log.isDebugEnabled()) {
 
 Review comment:
   log.debug(..) has this check inside it , you can use string format instead of string concatenation and remove this check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org