You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2025/12/05 07:26:11 UTC

[PR] MINOR: [Python] Remove obsolete is_map TODO comment [arrow]

HyukjinKwon opened a new pull request, #48353:
URL: https://github.com/apache/arrow/pull/48353

   ### Rationale for this change
   
   This TODO was added in https://github.com/apache/arrow/commit/eaeb5d4820ce36484aaa78a15fe5bf957a53651e. However, now we have map support properly, and its test was added in https://github.com/apache/arrow/commit/e0c1ffe9c38d1759f1b5311f95864b0e2a406c51
   
   ### What changes are included in this PR?
   
   This PR proposes to remove obsolete is_map TODO comment.
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: [Python] Remove obsolete is_map TODO comment [arrow]

Posted by "AlenkaF (via GitHub)" <gi...@apache.org>.
AlenkaF merged PR #48353:
URL: https://github.com/apache/arrow/pull/48353


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: [Python] Remove obsolete is_map TODO comment [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48353:
URL: https://github.com/apache/arrow/pull/48353#issuecomment-3672448732

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5499afa67c924d27e3bbb578685c89e87448553e.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/58481266565) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: [Python] Remove obsolete is_map TODO comment [arrow]

Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #48353:
URL: https://github.com/apache/arrow/pull/48353#issuecomment-3616044406

   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org