[jira] [Commented] (PHOENIX-5561) Map.getOrDefault usage in ConnectionQueryServiceImpl requires JDK 8

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972008#comment-16972008 ] 

Hadoop QA commented on PHOENIX-5561:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12985563/PHOENIX-5561.4.x.001.patch
  against master branch at commit dd5551b4e8cc17e5bd587e6c4f5f256a8212345a.
  ATTACHMENT ID: 12985563

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PermissionNSEnabledIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3114//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3114//console

This message is automatically generated.

> Map.getOrDefault usage in ConnectionQueryServiceImpl requires JDK 8
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-5561
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5561
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.15.1
>            Reporter: Geoffrey Jacoby
>            Assignee: Gokcen Iskender
>            Priority: Blocker
>         Attachments: PHOENIX-5561.4.x.001.patch, PHOENIX-5561.master.001.patch
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> PHOENIX-5553 introduced a usage of Map.getOrDefault(), which requires JDK 8. It was checked into the 4.x branch, even though the 4.x branch should still allow usage by JDK 7 (since HBase 1.x supports JDK 7). 
> If we want to change that assumption, it should be agreed on by the community.
> See CQSI line 926
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)