You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/30 07:18:43 UTC
[GitHub] [openwhisk] ningyougang opened a new pull request #4870: Calculate
whether exist enough space more carefully
ningyougang opened a new pull request #4870: Calculate whether exist enough space more carefully
URL: https://github.com/apache/openwhisk/pull/4870
<!--- Provide a concise summary of your changes in the Title -->
## Description
<!--- Provide a detailed description of your changes. -->
<!--- Include details of what problem you are solving and how your changes are tested. -->
Take prewarmedPool's memory to used invoker memory
## Related issue and scope
<!--- Please include a link to a related issue if there is one. -->
- [ ] I opened an issue to propose and discuss this change (#????)
## My changes affect the following components
<!--- Select below all system components are affected by your change. -->
<!--- Enter an `x` in all applicable boxes. -->
- [ ] API
- [ ] Controller
- [ ] Message Bus (e.g., Kafka)
- [ ] Loadbalancer
- [x] Invoker
- [ ] Intrinsic actions (e.g., sequences, conductors)
- [ ] Data stores (e.g., CouchDB)
- [ ] Tests
- [ ] Deployment
- [ ] CLI
- [ ] General tooling
- [ ] Documentation
## Types of changes
<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
- [ ] Bug fix (generally a non-breaking change which closes an issue).
- [x] Enhancement or new feature (adds new functionality).
- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [ ] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [ ] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
- [ ] I added tests to cover my changes.
- [ ] My changes require further changes to the documentation.
- [ ] I updated the documentation where necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] ningyougang commented on issue #4870: Calculate whether
exist enough space more carefully
Posted by GitBox <gi...@apache.org>.
ningyougang commented on issue #4870: Calculate whether exist enough space more carefully
URL: https://github.com/apache/openwhisk/pull/4870#issuecomment-606410540
Close it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] markusthoemmes commented on a change in pull request
#4870: Calculate whether exist enough space more carefully
Posted by GitBox <gi...@apache.org>.
markusthoemmes commented on a change in pull request #4870: Calculate whether exist enough space more carefully
URL: https://github.com/apache/openwhisk/pull/4870#discussion_r399976882
##########
File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
##########
@@ -119,7 +127,7 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
}
val createdContainer =
// Is there enough space on the invoker for this action to be executed.
- if (hasPoolSpaceFor(busyPool, r.action.limits.memory.megabytes.MB)) {
+ if (hasPoolSpaceFor(busyPool ++ prewarmedPoolForOtherKind, r.action.limits.memory.megabytes.MB)) {
Review comment:
I'd think we explicitly do not want to have the prewarm pool survive, if other actions would benefit from using that space. After all, it's a performance optimization, not a guarantee.
Wouldn't this also be plumbed into the controller for it to not send requests down a path where they might not get executed?
I think this warrants a dev-list discussion 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] ningyougang commented on a change in pull request
#4870: Calculate whether exist enough space more carefully
Posted by GitBox <gi...@apache.org>.
ningyougang commented on a change in pull request #4870: Calculate whether exist enough space more carefully
URL: https://github.com/apache/openwhisk/pull/4870#discussion_r400006792
##########
File path: core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerPool.scala
##########
@@ -119,7 +127,7 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
}
val createdContainer =
// Is there enough space on the invoker for this action to be executed.
- if (hasPoolSpaceFor(busyPool, r.action.limits.memory.megabytes.MB)) {
+ if (hasPoolSpaceFor(busyPool ++ prewarmedPoolForOtherKind, r.action.limits.memory.megabytes.MB)) {
Review comment:
Sorry, i didn't get it,
anyway i send a email to dev-list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] ningyougang closed pull request #4870: Calculate
whether exist enough space more carefully
Posted by GitBox <gi...@apache.org>.
ningyougang closed pull request #4870: Calculate whether exist enough space more carefully
URL: https://github.com/apache/openwhisk/pull/4870
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services