You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "gaborkaszab (via GitHub)" <gi...@apache.org> on 2026/05/08 07:56:11 UTC
[PR] Spec, Core: Disambiguate the intent of REFS snapshot mode [iceberg]
gaborkaszab opened a new pull request, #16252:
URL: https://github.com/apache/iceberg/pull/16252
Spell out that it has an effect on the 'snapshots' and not the 'snapshot-log' part of the response. Some implementations already got it wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Spec, Core: Disambiguate the intent of REFS snapshot mode [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #16252:
URL: https://github.com/apache/iceberg/pull/16252#discussion_r3207627415
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -1265,6 +1282,14 @@ public void lazySnapshotLoadingWithDivergedHistory() {
.asInstanceOf(InstanceOfAssertFactories.list(Snapshot.class))
.hasSize(1);
+ // snapshot log is complete regardless REFS mode
+ assertThat(((BaseTable) refsTable).operations().current())
+ .extracting("snapshotLog")
+ .asInstanceOf(InstanceOfAssertFactories.list(HistoryEntry.class))
+ .hasSize(5)
Review Comment:
```suggestion
.hasSize(numSnapshots)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] OpenAPI, Core: Disambiguate the intent of REFS snapshot mode [iceberg]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #16252:
URL: https://github.com/apache/iceberg/pull/16252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org