You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by "William A. Rowe, Jr." <wr...@rowe-clan.net> on 2005/07/01 20:33:38 UTC

NOTE To All Dev's!!!

I have bumped the MODULE_MAGIC_COOKIE for 2.1.7.  This will be
bumped again upon 2.2 release to "AP22".

The modules are significantly disjoint, and testing for the
mmn date and level between a 2.0 and 2.1 module will not produce
the desired results.

Please forgive any inconvenience this may cause, but you must rebuild
all in order to continue using modules against 2.1.

Bill

>Author: wrowe
>Date: Fri Jul  1 10:50:01 2005
>New Revision: 208777
>
>Log:
>
>  Change Apache httpd 2.1 signature to "AP21" as this flavor
>  is binary-incompatible to any "AP20" module.

>-#define MODULE_MAGIC_COOKIE 0x41503230UL /* "AP20" */
>+#define MODULE_MAGIC_COOKIE 0x41503231UL /* "AP21" */

>-#define MODULE_MAGIC_NUMBER_MAJOR 20050305
>+#define MODULE_MAGIC_NUMBER_MAJOR 20050701

>-#define MODULE_MAGIC_NUMBER_MINOR 3                     /* 0...n */
>+#define MODULE_MAGIC_NUMBER_MINOR 0                     /* 0...n */



Re: NOTE To All Dev's!!!

Posted by Paul Querna <ch...@force-elite.com>.
William A. Rowe, Jr. wrote:

>I have bumped the MODULE_MAGIC_COOKIE for 2.1.7.  This will be
>bumped again upon 2.2 release to "AP22".
>  
>

No. This does not make sense.

If we don't break the binary API, there is no reason to bump it to AP22.

Just because we release 2.2.0, it doesn't mean a binary module for 2.1.x 
will not work just fine.  The MMN is there for this exact reason.

>The modules are significantly disjoint, and testing for the
>mmn date and level between a 2.0 and 2.1 module will not produce
>the desired results.
>
>  
>
If Vendors want to change the MMN values, that is their problem.  
2.0.x's Major will not change ever again.  The MMN should be for the 
'official' binary API.  If other groups want a method to change this, 
maybe we could do something, but even for them, just bumping the MMN is 
the wrong solution.

>Please forgive any inconvenience this may cause, but you must rebuild
>all in order to continue using modules against 2.1.
>  
>

It is an inconvenience, and a big enough change I would of preferred 
that the list be at least consulted before it was committed. Yes, trunk 
is CTR, but it wouldn't of been a huge deal to discuss this type of 
policy and code change before doing it.

-Paul

Re: NOTE To All Dev's!!!

Posted by Sander Striker <st...@apache.org>.
William A. Rowe, Jr. wrote:
> I have bumped the MODULE_MAGIC_COOKIE for 2.1.7.  This will be
> bumped again upon 2.2 release to "AP22".

-1.
 
> The modules are significantly disjoint, and testing for the
> mmn date and level between a 2.0 and 2.1 module will not produce
> the desired results.

Given that 2.0 should remain binary compat, there is no need to bump
the magic cookie.

> Please forgive any inconvenience this may cause, but you must rebuild
> all in order to continue using modules against 2.1.

I don't understand the need.  Let's discuss this first.

Thanks,

Sander

Re: [vote] MODULE_MAGIC_COOKIE

Posted by Sander Striker <st...@apache.org>.
William A. Rowe, Jr. wrote:
> At 01:33 PM 7/1/2005, William A. Rowe, Jr. wrote:
> 
>>I have bumped the MODULE_MAGIC_COOKIE for 2.1.7.  This will be
>>bumped again upon 2.2 release to "AP22".
>>
>>
>>>-#define MODULE_MAGIC_COOKIE 0x41503230UL /* "AP20" */
>>>+#define MODULE_MAGIC_COOKIE 0x41503231UL /* "AP21" */
> 
> 
> The question remains, so please choose one;
> 
>   [ ] Revert the cookie to AP20 for httpd-2.1 and httpd-2.2
>   [ ] Leave the cookie at AP21 and bump again to AP22 w/httpd-2.2
>   [X] Get it over with already and bump now to AP22 for httpd-2.1

Sander

Re: [vote] MODULE_MAGIC_COOKIE

Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
On Thu, Jul 07, 2005 at 10:51:09PM -0500, William A. Rowe, Jr. wrote:
>   [ ] Revert the cookie to AP20 for httpd-2.1 and httpd-2.2
>   [ ] Leave the cookie at AP21 and bump again to AP22 w/httpd-2.2
>   [X] Get it over with already and bump now to AP22 for httpd-2.1

Re: [vote] MODULE_MAGIC_COOKIE

Posted by Graham Leggett <mi...@sharp.fm>.
William A. Rowe, Jr. wrote:

>   [ ] Revert the cookie to AP20 for httpd-2.1 and httpd-2.2
>   [ ] Leave the cookie at AP21 and bump again to AP22 w/httpd-2.2
>   [X] Get it over with already and bump now to AP22 for httpd-2.1


Regards,
Graham
--

Re: [vote] MODULE_MAGIC_COOKIE

Posted by Paul Querna <ch...@force-elite.com>.
 > The question remains, so please choose one;

>  [ ] Revert the cookie to AP20 for httpd-2.1 and httpd-2.2
>  [ ] Leave the cookie at AP21 and bump again to AP22 w/httpd-2.2
>  [X] Get it over with already and bump now to AP22 for httpd-2.1
>  
>
-Paul

[vote] MODULE_MAGIC_COOKIE

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
At 01:33 PM 7/1/2005, William A. Rowe, Jr. wrote:
>I have bumped the MODULE_MAGIC_COOKIE for 2.1.7.  This will be
>bumped again upon 2.2 release to "AP22".
>
>>-#define MODULE_MAGIC_COOKIE 0x41503230UL /* "AP20" */
>>+#define MODULE_MAGIC_COOKIE 0x41503231UL /* "AP21" */

The question remains, so please choose one;

  [ ] Revert the cookie to AP20 for httpd-2.1 and httpd-2.2
  [ ] Leave the cookie at AP21 and bump again to AP22 w/httpd-2.2
  [ ] Get it over with already and bump now to AP22 for httpd-2.1

Bill