You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/08/03 08:14:12 UTC
[GitHub] [echarts-doc] gitforhlp opened a new pull request, #279: delete hightlight and downplay doc
gitforhlp opened a new pull request, #279:
URL: https://github.com/apache/echarts-doc/pull/279
fix [issues#185](https://github.com/apache/echarts-doc/issues/185)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] plainheart commented on a diff in pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
plainheart commented on code in PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#discussion_r936398883
##########
en/api/action.md:
##########
@@ -36,54 +36,6 @@ Chart actions supported by ECharts are triggered through [dispatchAction](~echar
**Attention: ** The `?:` note in the code shows that this attribute is optional. *EVENT:* stands for the event that triggers action.
-## highlight(Action)
Review Comment:
We shouldn't remove them as they are still working for other series or components.
The v5 upgrade guide indicates that the `highlight` action & `downplay` action in the `sunburst` series are deprecated but not in all series.
Perhaps we should add new actions for `sunburstHighlight` & `sunburstUnhighlight`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] Ovilia commented on pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#issuecomment-1230021334
apache/echarts#17587 is following the right track. I think there should be no document changing required so I'm going to close this PR. Thanks for the help!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] gitforhlp commented on pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
gitforhlp commented on PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#issuecomment-1229895722
> I was confused because `highlight` is new introduced since 5.0 and it should not be deprecated. So I just did some search in the code and it seems the warning log is wrong in https://github.com/apache/echarts/blob/master/src/chart/sunburst/sunburstAction.ts#L90
>
> It should be.
>
> ```ts
> deprecateReplaceLog('sunburstHighlight', 'highlight');
> ```
>
> So we should change this warning log instead of changing the doc
It is stated in the V5 document that this is discarded in the sunrise chart, please check again
[https://echarts.apache.org/handbook/zh/basics/release-note/v5-upgrade-guide/#%E4%B8%8D%E5%86%8D%E6%8E%A8%E8%8D%90%E4%BD%BF%E7%94%A8%E7%9A%84-api](url)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] pissang commented on pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
pissang commented on PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#issuecomment-1229867665
I was confused because `highlight` is new introduced since 5.0 and it should not be deprecated. So I just did some search in the code and it seems the warning log is wrong in https://github.com/apache/echarts/blob/master/src/chart/sunburst/sunburstAction.ts#L90
It should be.
```ts
deprecateReplaceLog('sunburstHighlight', 'highlight');
```
So we should change this warning log instead of changing the doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] gitforhlp commented on pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
gitforhlp commented on PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#issuecomment-1229892367
> I was confused because `highlight` is new introduced since 5.0 and it should not be deprecated. So I just did some search in the code and it seems the warning log is wrong in https://github.com/apache/echarts/blob/master/src/chart/sunburst/sunburstAction.ts#L90
> It is stated in the V5 document that this is discarded in the sunrise chart, and it is not a code problem
> It should be.
>
> ```ts
> deprecateReplaceLog('sunburstHighlight', 'highlight');
> ```
>
> So we should change this warning log instead of changing the doc
It is stated in the V5 document that this is discarded in the sunrise chart, and it is not a code problem,please check again
[https://echarts.apache.org/handbook/zh/basics/release-note/v5-upgrade-guide/#%E4%B8%8D%E5%86%8D%E6%8E%A8%E8%8D%90%E4%BD%BF%E7%94%A8%E7%9A%84-api](url)![Uploading image.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] gitforhlp commented on pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
gitforhlp commented on PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#issuecomment-1229906012
It is stated in the V5 upgrade document that this is discarded in the sunrise chart,please check again
https://echarts.apache.org/handbook/zh/basics/release-note/v5-upgrade-guide#%E4%B8%8D%E5%86%8D%E6%8E%A8%E8%8D%90%E4%BD%BF%E7%94%A8%E7%9A%84-api
旭日图（sunburst）：
动作类型 highlight 已被弃用，请使用 sunburstHighlight 代替。
动作类型 downplay 已被弃用，请使用 sunburstUnhighlight 代替。
选项 series.downplay 已被弃用，请使用 series.blur 代替。
选项 series.highlightPolicy 已不适用，请使用 series.emphasis.focus 代替。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] pissang commented on pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
pissang commented on PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#issuecomment-1229805082
As @plainheart said, this change is only scoped to the sunburst series, it should be in mentioned in the note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] Ovilia closed pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
Ovilia closed pull request #279: delete hightlight and downplay doc
URL: https://github.com/apache/echarts-doc/pull/279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] Ovilia commented on pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#issuecomment-1225115486
@pissang Please help review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts-doc] gitforhlp commented on pull request #279: delete hightlight and downplay doc
Posted by GitBox <gi...@apache.org>.
gitforhlp commented on PR #279:
URL: https://github.com/apache/echarts-doc/pull/279#issuecomment-1229886807
> I was confused because `highlight` is new introduced since 5.0 and it should not be deprecated. So I just did some search in the code and it seems the warning log is wrong in https://github.com/apache/echarts/blob/master/src/chart/sunburst/sunburstAction.ts#L90
>
> It should be.
>
> ```ts
> deprecateReplaceLog('sunburstHighlight', 'highlight');
> ```
>
> So we should change this warning log instead of changing the doc
It is stated in the V5 document that this is discarded in the sunrise chart, and it is not a code problem
[](https://echarts.apache.org/handbook/zh/basics/release-note/v5-upgrade-guide#%E4%B8%8D%E5%86%8D%E6%8E%A8%E8%8D%90%E4%BD%BF%E7%94%A8%E7%9A%84-api)
![Uploading image.png…]()
please review again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org