[GitHub] [iceberg] stevenzwu commented on a change in pull request #2591: Spark: RewriteDatafilesAction V2

[GitBox <gi...@apache.org>]

stevenzwu commented on a change in pull request #2591:
URL: https://github.com/apache/iceberg/pull/2591#discussion_r632299092



##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkWriteOptions.java
##########
@@ -50,4 +50,7 @@ private SparkWriteOptions() {
 
   // File scan task set ID that indicates which files must be replaced
   public static final String REWRITTEN_FILE_SCAN_TASK_SET_ID = "rewritten-file-scan-task-set-id";
+
+  // Partition spec ID to use when writing new files
+  public static final String SPEC_ID = "spec-id";

Review comment:
       should we make the constant from `PartitionSpecParser` public? then we don't have define it here as it is a more general constant than spark




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org