You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/03/02 23:40:20 UTC

Re: Review Request 65310: Added lambda::zip.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65310/#review198563
-----------------------------------------------------------




3rdparty/stout/include/stout/lambda.hpp
Line 22 (original), 22 (patched)
<https://reviews.apache.org/r/65310/#comment278767>

    In description:
    s/pyhton/python/



3rdparty/stout/include/stout/lambda.hpp
Lines 169-170 (patched)
<https://reviews.apache.org/r/65310/#comment278769>

    Nit: enclose `std::pair` and `std::tuple` in backticks, for consistency.



3rdparty/stout/include/stout/lambda.hpp
Lines 202 (patched)
<https://reviews.apache.org/r/65310/#comment278768>

    s/parametrize/parametrized/


- Greg Mann


On Jan. 25, 2018, 3:34 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65310/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2018, 3:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Greg Mann.
> 
> 
> Bugs: MESOS-8434
>     https://issues.apache.org/jira/browse/MESOS-8434
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces the abstractions `lambda::zip` and `lambda::zipto` which
> provides a functionality similar to pyhton's  `zip()` call.
> 
> This patch supersedes the stalled review
> https://reviews.apache.org/r/63292/.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/lambda.hpp c9212be27b45da45f15371689f2aabf18c98657b 
>   3rdparty/stout/tests/lambda_tests.cpp 11b034306b11b95efa9bcd9811c5145ad39314a5 
> 
> 
> Diff: https://reviews.apache.org/r/65310/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>