You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mouchar (via GitHub)" <gi...@apache.org> on 2023/02/26 16:38:02 UTC
[GitHub] [pulsar-helm-chart] mouchar opened a new pull request, #348: Fix zookeeper annotations
mouchar opened a new pull request, #348:
URL: https://github.com/apache/pulsar-helm-chart/pull/348
Fixed the case when no ZK annotations are set and `zookeeper.restartPodsOnConfigMapChange: true` helm can not render template
### Motivation
When you don't set any annotations to Zookeeper (they are empty by default) AND if you set
```yaml
zookeeper.restartPodsOnConfigMapChange: true
```
in your values.yaml file, the manifest can not be rendered. This commit fixes this condition and also unifies the
the way how the custom annotations are added, with bookkeeper statefulset template.
```
helm template pulsar apache/pulsar --version 3.0.0 --set zookeeper.restartPodsOnConfigMapChange=true
Error: YAML parse error on pulsar/templates/zookeeper-statefulset.yaml: error converting YAML to JSON: yaml: line 52: did not find expected key
Use --debug flag to render out invalid YAML
```
### Modifications
wrapping `toYaml` filter (that can return empty object `{}`) into `with` context.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] lhotari merged pull request #348: Fix zookeeper annotations
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari merged PR #348:
URL: https://github.com/apache/pulsar-helm-chart/pull/348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] mouchar commented on pull request #348: Fix zookeeper annotations
Posted by "mouchar (via GitHub)" <gi...@apache.org>.
mouchar commented on PR #348:
URL: https://github.com/apache/pulsar-helm-chart/pull/348#issuecomment-1455819314
ping - any feedback?
Sorry, but I don't know how to "Make sure that the change passes the CI checks." when the Kind cluster doesn't start at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org