You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Madhuka <gi...@git.apache.org> on 2015/07/09 07:14:57 UTC
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
GitHub user Madhuka opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/147
ZEPPELIN-161: Fixing test in zeppelin-web
All the test in zeppelin web was failed. Contain older version code
Here is the fixed.
- [x] Fixing Karma config
- [x] Updating test spec for current code base version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Madhuka/incubator-zeppelin milestone05-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/147.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #147
----
commit 828b4ce29bd15ab515d17af925351375305267c0
Author: madhuka <ma...@gmail.com>
Date: 2015-07-08T16:00:10Z
Fixing karma config on path and bower_component
commit 9da6539e165a9fc9bf727eea1ce779f6a66757df
Author: madhuka <ma...@gmail.com>
Date: 2015-07-09T05:04:09Z
Fixing test in zeppelin web app and Karma conf
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-120798551
Having tests running is great!
Can you please add smth like `./grunt buildSkipTests` profile so we can use it in CI too.
Another thing I suggest - can you please create an issue in Zeppelin JIRA for integration frontend tests w/ CI (in a way that `mvn package -DskipTests` skip them too)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/147
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-129592781
#179 is merged. Could you close this PR? :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122206388
No clue why it failed on Lens Interpreter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122230656
why would adding components to karma.conf break the CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122182729
Are you up to date with master? (If not, can you try rebasing incubator-zeppelin master in your branch)
```
# while staying in your branch
git add remote incubator-zeppelin https://github.com/apache/incubator-zeppelin.git
git fetch incubator-zeppelin
git rebase incubator-zeppelin/master
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-121624555
I just check the log file for the PR
It shows, no failure in web app or grunt
[INFO] Running "wiredep:app" (wiredep) task
[INFO]
[INFO] Running "wiredep:test" (wiredep) task
[INFO]
[INFO] Running "useminPrepare:html" (useminPrepare) task
[INFO] Configuration changed for concat, uglify, cssmin
[INFO]
[INFO] Running "concurrent:dist" (concurrent) task
[INFO]
[INFO] Running "copy:styles" (copy) task
[INFO] Copied 6 files
[INFO]
[INFO] Done, without errors.
[INFO]
[INFO]
[INFO] Execution Time (2015-07-15 12:22:54 UTC)
[INFO] loading tasks 7ms ▇▇▇▇▇▇▇▇ 16%
[INFO] copy:styles 36ms ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ 82%
[INFO] Total 44ms
[INFO]
[INFO] Running "svgmin:dist" (svgmin) task
[INFO] Total saved: 0 B
[INFO]
[INFO] Done, without errors.
I try in local it work fine.
any idea?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-120942795
`./grunt buildSkipTests` will build without test. It can be used in CI
`./grunt build` will contain the test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-120803179
Isn't more something like:
- Add test inside of ``./grunt build`` rule
- Create a ``./grunt buildSkipTests`` rule (current build) so that we use it in maven
Since CI needs to run the tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by AyolaJayamaha <gi...@git.apache.org>.
Github user AyolaJayamaha commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-126992062
@Leemoonsoo : Ready for Merge
@bzz, @corneadoug This contain the fixed for grunt test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-129697099
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122233939
Not sure of that Cl break for that, that regex is correct and all things
are fine.
I check the logs and I did not find any reason of break even.
what is CI spec (server/os spec)? Some time regex did not able to handle
file directory upon server spec. :/
as there are '-' in directory though it is said so.
- **/*.js: All files with a "js" extension in all subdirectories
[1] http://karma-runner.github.io/0.10/config/configuration-file.html
On Fri, Jul 17, 2015 at 3:14 PM, CORNEAU Damien <no...@github.com>
wrote:
> why would adding components to karma.conf break the CI?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122230656>
> .
>
--
Cheers,
Madhuka Udantha
http://madhukaudantha.blogspot.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-120754540
Ping!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-119821312
Run the web application Test
`grunt test`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-126992099
@Leemoonsoo : Ready for Merge
@bzz, @corneadoug This contain the fixed for grunt test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122223923
@corneadoug : Cl tests are pass now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122182265
incubator-zeppelin\zeppelin-web>mvn verify
BUILD SUCCESS
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0
approved: 36 licence.
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 03:42 min
[INFO] Finished at: 2015-07-17T10:53:34+05:30
[INFO] Final Memory: 30M/498M
[INFO]
------------------------------------------------------------------------
On Fri, Jul 17, 2015 at 10:06 AM, CORNEAU Damien <no...@github.com>
wrote:
> Can you try mvn verify inside zeppelin-web folder?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122169985>
> .
>
--
Cheers,
Madhuka Udantha
http://madhukaudantha.blogspot.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by AyolaJayamaha <gi...@git.apache.org>.
Github user AyolaJayamaha commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122222606
@corneadoug
now CI build pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122169985
Can you try `` mvn verify `` inside zeppelin-web folder?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-127564238
Here is the new PR[1] since this PR contains merging issues.
[1] https://github.com/apache/incubator-zeppelin/pull/179
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-127110249
Does anybody know why this PR contains things like c46d8a0 Flink modifications from #142 ?
It does not seems to me that it is possible to merge it as-is, because of that, or am I missing something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-122205282
Seems like it didn't go well, there is duplicate commits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: ZEPPELIN-161: Fixing test in zepp...
Posted by Madhuka <gi...@git.apache.org>.
Github user Madhuka commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-127114725
Yes, c46d8a0
<https://github.com/apache/incubator-zeppelin/commit/c46d8a01030e7d1ca41320cf4467a706f46167e5>
was
mistaken of re-basing. This PR no need of c46d8a0
<https://github.com/apache/incubator-zeppelin/commit/c46d8a01030e7d1ca41320cf4467a706f46167e5>
On Mon, Aug 3, 2015 at 8:49 AM, Alexander <no...@github.com> wrote:
> Does anybody know why this PR contains things like c46d8a0
> <https://github.com/apache/incubator-zeppelin/commit/c46d8a01030e7d1ca41320cf4467a706f46167e5>
> Flink modifications from #142
> <https://github.com/apache/incubator-zeppelin/pull/142> ?
> It does not seems to me that it is possible to merge it as-is, because of
> that, or am I missing something?
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-zeppelin/pull/147#issuecomment-127110249>
> .
>
--
Cheers,
Madhuka Udantha
http://madhukaudantha.blogspot.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---