You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2020/07/31 19:09:32 UTC
Review Request 72728: Added a unit test for the CSI server.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs
-----
src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/1/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221552
-----------------------------------------------------------
src/tests/csi_server_tests.cpp
Lines 89-92 (original)
<https://reviews.apache.org/r/72728/#comment310619>
Instead of removing this, I think we may need to implement the `TearDown` method to do some cleanup like: https://github.com/apache/mesos/blob/1.10.0/src/tests/storage_local_resource_provider_tests.cpp#L163:L187
WDYT?
- Qian Zhang
On Aug. 11, 2020, 11:08 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2020, 11:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/3/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Qian Zhang <zh...@gmail.com>.
> On Aug. 12, 2020, 11:18 a.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 114-121 (patched)
> > <https://reviews.apache.org/r/72728/diff/3/?file=2237793#file2237793line114>
> >
> > It seems the required flag [--endpoint](https://github.com/apache/mesos/blob/1.10.0/src/examples/test_csi_plugin.cpp#L130:L132) is not set here?
Sorry, the link to the `--endpoint` should be https://github.com/apache/mesos/blob/1.10.0/src/examples/test_csi_plugin.cpp#L130:L132
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221553
-----------------------------------------------------------
On Aug. 11, 2020, 11:08 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2020, 11:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/3/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Aug. 12, 2020, 3:18 a.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 96 (patched)
> > <https://reviews.apache.org/r/72728/diff/3/?file=2237793#file2237793line96>
> >
> > Why do we need this parameter?
Yea I can get rid of this, thanks!
> On Aug. 12, 2020, 3:18 a.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 114-121 (patched)
> > <https://reviews.apache.org/r/72728/diff/3/?file=2237793#file2237793line114>
> >
> > It seems the required flag [--endpoint](https://github.com/apache/mesos/blob/1.10.0/src/examples/test_csi_plugin.cpp#L130:L132) is not set here?
>
> Qian Zhang wrote:
> Sorry, the link to the `--endpoint` should be https://github.com/apache/mesos/blob/1.10.0/src/examples/test_csi_plugin.cpp#L130:L132
I had to look through the code; it turns out the service manager injects the endpoint flag for managed plugins: https://github.com/apache/mesos/blob/831f172de7908ad8e40d14905cacb3a9c053e832/src/csi/service_manager.cpp#L713-L727
Maybe I should add a comment here mentioning that the flag is injected elsewhere?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221553
-----------------------------------------------------------
On Aug. 13, 2020, 6:38 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2020, 6:38 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/4/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221553
-----------------------------------------------------------
src/tests/csi_server_tests.cpp
Lines 96 (patched)
<https://reviews.apache.org/r/72728/#comment310621>
Why do we need this parameter?
src/tests/csi_server_tests.cpp
Lines 114-121 (patched)
<https://reviews.apache.org/r/72728/#comment310620>
It seems the required flag [--endpoint](https://github.com/apache/mesos/blob/1.10.0/src/examples/test_csi_plugin.cpp#L130:L132) is not set here?
- Qian Zhang
On Aug. 11, 2020, 11:08 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2020, 11:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/3/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221562
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72732, 72716, 72690, 72733, 72734, 72753, 72754, 72726, 72727, 72761, 72760, 72728]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Aug. 12, 2020, 7:21 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2020, 7:21 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/4/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added unit tests for the CSI server.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221681
-----------------------------------------------------------
Bad patch!
Reviews applied: [72728, 72761, 72726, 72754, 72753, 72734, 72733, 72690, 72716, 72732]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72728
Error:
2020-08-21 23:45:17 URL:https://reviews.apache.org/r/72728/diff/raw/ [17182/17182] -> "72728.patch" [1]
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <je...@asf931.gq1.ygridcore.net>) not allowed
Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/23/console
- Mesos Reviewbot
On Aug. 21, 2020, 4:34 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2020, 4:34 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests for the CSI server.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/9/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added unit tests for the CSI server.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221699
-----------------------------------------------------------
Bad patch!
Reviews applied: [72728, 72727, 72726, 72754, 72753, 72734, 72733, 72690, 72716, 72732]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72727
Error:
2020-08-24 23:56:34 URL:https://reviews.apache.org/r/72727/diff/raw/ [7515/7515] -> "72727.patch" [1]
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <je...@asf934.gq1.ygridcore.net>) not allowed
Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/90/console
- Mesos Reviewbot
On Aug. 24, 2020, 9:20 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2020, 9:20 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests for the CSI server.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/9/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Qian Zhang <zh...@gmail.com>.
> On Aug. 25, 2020, 10:41 p.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 457 (patched)
> > <https://reviews.apache.org/r/72728/diff/9/?file=2238569#file2238569line457>
> >
> > It seems we only want to verify the behavior of CSI server but not launch a task from end to end, maybe we do not need to start master and agent just like what we do in `ROOT_InvalidPluginConfig`?
>
> Greg Mann wrote:
> In this case, we still need the agent so that the CSI plugin can actually be initialized successfully.
>
> Another option for this test would be to use a task launch to test this same thing from end-to-end. I left it as-is because the task launching boilerplate makes the test much larger, so this version is more concise. WDYT?
>
> Qian Zhang wrote:
> > In this case, we still need the agent so that the CSI plugin can actually be initialized successfully.
>
> Could you please elaborate a bit on this? Why do we need agent to make sure the CSI plugin can actually be initialized? It seems we only need agent ID when calling `csiServer.get()->start()`, but I think we can pass it a mock agent ID like what `ROOT_InvalidPluginConfig` does, right?
>
> Greg Mann wrote:
> Plugin initialization makes calls against the agent API in order to launch the plugin. Without doing that, publish/unpublish calls cannot succeed.
I see, thanks!
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221703
-----------------------------------------------------------
On Aug. 27, 2020, 2:12 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 27, 2020, 2:12 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/11/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Aug. 25, 2020, 2:41 p.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 457 (patched)
> > <https://reviews.apache.org/r/72728/diff/9/?file=2238569#file2238569line457>
> >
> > It seems we only want to verify the behavior of CSI server but not launch a task from end to end, maybe we do not need to start master and agent just like what we do in `ROOT_InvalidPluginConfig`?
In this case, we still need the agent so that the CSI plugin can actually be initialized successfully.
Another option for this test would be to use a task launch to test this same thing from end-to-end. I left it as-is because the task launching boilerplate makes the test much larger, so this version is more concise. WDYT?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221703
-----------------------------------------------------------
On Aug. 26, 2020, 5:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2020, 5:57 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/10/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Qian Zhang <zh...@gmail.com>.
> On Aug. 25, 2020, 10:41 p.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 457 (patched)
> > <https://reviews.apache.org/r/72728/diff/9/?file=2238569#file2238569line457>
> >
> > It seems we only want to verify the behavior of CSI server but not launch a task from end to end, maybe we do not need to start master and agent just like what we do in `ROOT_InvalidPluginConfig`?
>
> Greg Mann wrote:
> In this case, we still need the agent so that the CSI plugin can actually be initialized successfully.
>
> Another option for this test would be to use a task launch to test this same thing from end-to-end. I left it as-is because the task launching boilerplate makes the test much larger, so this version is more concise. WDYT?
> In this case, we still need the agent so that the CSI plugin can actually be initialized successfully.
Could you please elaborate a bit on this? Why do we need agent to make sure the CSI plugin can actually be initialized? It seems we only need agent ID when calling `csiServer.get()->start()`, but I think we can pass it a mock agent ID like what `ROOT_InvalidPluginConfig` does, right?
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221703
-----------------------------------------------------------
On Aug. 26, 2020, 1:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2020, 1:57 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/10/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Aug. 25, 2020, 2:41 p.m., Qian Zhang wrote:
> > src/tests/csi_server_tests.cpp
> > Lines 457 (patched)
> > <https://reviews.apache.org/r/72728/diff/9/?file=2238569#file2238569line457>
> >
> > It seems we only want to verify the behavior of CSI server but not launch a task from end to end, maybe we do not need to start master and agent just like what we do in `ROOT_InvalidPluginConfig`?
>
> Greg Mann wrote:
> In this case, we still need the agent so that the CSI plugin can actually be initialized successfully.
>
> Another option for this test would be to use a task launch to test this same thing from end-to-end. I left it as-is because the task launching boilerplate makes the test much larger, so this version is more concise. WDYT?
>
> Qian Zhang wrote:
> > In this case, we still need the agent so that the CSI plugin can actually be initialized successfully.
>
> Could you please elaborate a bit on this? Why do we need agent to make sure the CSI plugin can actually be initialized? It seems we only need agent ID when calling `csiServer.get()->start()`, but I think we can pass it a mock agent ID like what `ROOT_InvalidPluginConfig` does, right?
Plugin initialization makes calls against the agent API in order to launch the plugin. Without doing that, publish/unpublish calls cannot succeed.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221703
-----------------------------------------------------------
On Aug. 26, 2020, 5:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2020, 5:57 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/10/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added unit tests for the CSI server.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221703
-----------------------------------------------------------
src/tests/csi_server_tests.cpp
Lines 19 (patched)
<https://reviews.apache.org/r/72728/#comment310753>
It seems we do not need this?
src/tests/csi_server_tests.cpp
Lines 106-107 (patched)
<https://reviews.apache.org/r/72728/#comment310754>
A newline between. Ditto for line 111-112.
src/tests/csi_server_tests.cpp
Lines 403 (patched)
<https://reviews.apache.org/r/72728/#comment310758>
I do not see how this volume is used by the task, I think we should set the volume into the task's `containerInfo.volumes`.
src/tests/csi_server_tests.cpp
Lines 408 (patched)
<https://reviews.apache.org/r/72728/#comment310757>
Can we launch the task to run a command to write to the volume rather than just `exit 0`?
src/tests/csi_server_tests.cpp
Lines 457 (patched)
<https://reviews.apache.org/r/72728/#comment310759>
It seems we only want to verify the behavior of CSI server but not launch a task from end to end, maybe we do not need to start master and agent just like what we do in `ROOT_InvalidPluginConfig`?
- Qian Zhang
On Aug. 25, 2020, 5:20 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2020, 5:20 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit tests for the CSI server.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/9/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Aug. 26, 2020, 7:54 a.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 19 (patched)
> > <https://reviews.apache.org/r/72728/diff/10/?file=2238776#file2238776line19>
> >
> > Do we need this?
Whoops, you commented on this before. I removed it but I still had the change stashed locally, I'm sorry!
> On Aug. 26, 2020, 7:54 a.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 278-282 (patched)
> > <https://reviews.apache.org/r/72728/diff/10/?file=2238776#file2238776line278>
> >
> > Can we just do `Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), agentFlags);` instead?
`SlaveOptions` provides a more easily-maintained interface and is now the preferred way to start agents in our tests: https://github.com/apache/mesos/blob/62931a04f2cd2a1951d04bd348ff23700cc73d9b/src/tests/mesos.hpp#L258-L262
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221714
-----------------------------------------------------------
On Aug. 26, 2020, 5:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2020, 5:57 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/10/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221714
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/CMakeLists.txt
Lines 236 (patched)
<https://reviews.apache.org/r/72728/#comment310766>
I think this line should be moved to line 215 below. Ditto for the `src/Makefile.am` below.
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 19 (patched)
<https://reviews.apache.org/r/72728/#comment310767>
Do we need this?
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 254 (patched)
<https://reviews.apache.org/r/72728/#comment310768>
Can we add a description for this test?
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 274 (patched)
<https://reviews.apache.org/r/72728/#comment310769>
Kill this newline.
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 278-282 (patched)
<https://reviews.apache.org/r/72728/#comment310770>
Can we just do `Try<Owned<cluster::Slave>> slave = StartSlave(detector.get(), agentFlags);` instead?
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 541 (patched)
<https://reviews.apache.org/r/72728/#comment310771>
Do we want to unpublish the volume at the end of this test? Otherwise there will be a mount left on the host filesystem?
- Qian Zhang
On Aug. 26, 2020, 1:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2020, 1:57 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/10/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221724
-----------------------------------------------------------
Bad patch!
Reviews applied: [72728, 72805, 72727, 72726, 72754, 72753, 72734, 72733, 72690, 72716, 72732]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72727
Error:
2020-08-26 20:09:56 URL:https://reviews.apache.org/r/72727/diff/raw/ [7515/7515] -> "72727.patch" [1]
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <je...@asf931.gq1.ygridcore.net>) not allowed
Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/131/console
- Mesos Reviewbot
On Aug. 26, 2020, 6:12 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2020, 6:12 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/11/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221793
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Sept. 3, 2020, 3:05 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2020, 3:05 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/14/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Sept. 2, 2020, 7:05 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Added tests for the 'volume/csi' isolator.
Diffs (updated)
-----
src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63
src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/14/
Changes: https://reviews.apache.org/r/72728/diff/13-14/
Testing
-------
`sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`
Thanks,
Greg Mann
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Sept. 2, 2020, 1:35 p.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 238 (patched)
> > <https://reviews.apache.org/r/72728/diff/13/?file=2239017#file2239017line238>
> >
> > Do we really need this method? I see it is only called when we create CSI server in `ROOT_PluginConfigAddedAtRuntime`, can we just create the CSI server with NULL secret generator like what we do in `ROOT_InvalidPluginConfig`?
I'd rather leave it in, since it is also used by the subsequent tests in the next patch in this chain. In order to run these tests with authentication enabled, we need to create a secret generator. Since we have some nontrivial authentication code in these code paths, keeping authentication enabled seems like a good idea to me. What do you think?
> On Sept. 2, 2020, 1:35 p.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 794 (patched)
> > <https://reviews.apache.org/r/72728/diff/13/?file=2239017#file2239017line794>
> >
> > Usually we use `SUDO_USER` as the non-root user in our unit tests, see https://github.com/apache/mesos/blob/1.10.0/src/tests/containerizer/docker_volume_isolator_tests.cpp#L1335 . And the test name should have the `UNPRIVILEGED_USER_` prefix.
> >
> > Just realized in a couple of your tests here, we need to pull Docker image `alpine` from Docker Hub, right? Then I think we need to include the prefix `INTERNET_CURL_` in the test name.
Thanks!!
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221754
-----------------------------------------------------------
On Sept. 2, 2020, 5:57 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2020, 5:57 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/13/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
> On Sept. 2, 2020, 1:35 p.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 794 (patched)
> > <https://reviews.apache.org/r/72728/diff/13/?file=2239017#file2239017line794>
> >
> > Usually we use `SUDO_USER` as the non-root user in our unit tests, see https://github.com/apache/mesos/blob/1.10.0/src/tests/containerizer/docker_volume_isolator_tests.cpp#L1335 . And the test name should have the `UNPRIVILEGED_USER_` prefix.
> >
> > Just realized in a couple of your tests here, we need to pull Docker image `alpine` from Docker Hub, right? Then I think we need to include the prefix `INTERNET_CURL_` in the test name.
>
> Greg Mann wrote:
> Thanks!!
I ended up switching the tests to use a mixture of tasks with a rootfs and tasks without - let me know what you think.
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221754
-----------------------------------------------------------
On Sept. 2, 2020, 7:05 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2020, 7:05 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/14/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Qian Zhang <zh...@gmail.com>.
> On Sept. 2, 2020, 9:35 p.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 238 (patched)
> > <https://reviews.apache.org/r/72728/diff/13/?file=2239017#file2239017line238>
> >
> > Do we really need this method? I see it is only called when we create CSI server in `ROOT_PluginConfigAddedAtRuntime`, can we just create the CSI server with NULL secret generator like what we do in `ROOT_InvalidPluginConfig`?
>
> Greg Mann wrote:
> I'd rather leave it in, since it is also used by the subsequent tests in the next patch in this chain. In order to run these tests with authentication enabled, we need to create a secret generator. Since we have some nontrivial authentication code in these code paths, keeping authentication enabled seems like a good idea to me. What do you think?
Yeah, I agree.
> On Sept. 2, 2020, 9:35 p.m., Qian Zhang wrote:
> > src/tests/containerizer/volume_csi_isolator_tests.cpp
> > Lines 794 (patched)
> > <https://reviews.apache.org/r/72728/diff/13/?file=2239017#file2239017line794>
> >
> > Usually we use `SUDO_USER` as the non-root user in our unit tests, see https://github.com/apache/mesos/blob/1.10.0/src/tests/containerizer/docker_volume_isolator_tests.cpp#L1335 . And the test name should have the `UNPRIVILEGED_USER_` prefix.
> >
> > Just realized in a couple of your tests here, we need to pull Docker image `alpine` from Docker Hub, right? Then I think we need to include the prefix `INTERNET_CURL_` in the test name.
>
> Greg Mann wrote:
> Thanks!!
>
> Greg Mann wrote:
> I ended up switching the tests to use a mixture of tasks with a rootfs and tasks without - let me know what you think.
SGTM!
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221754
-----------------------------------------------------------
On Sept. 3, 2020, 3:05 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2020, 3:05 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/14/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221754
-----------------------------------------------------------
src/Makefile.am
Lines 2875 (patched)
<https://reviews.apache.org/r/72728/#comment310831>
The indent seems not correct.
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 21-22 (patched)
<https://reviews.apache.org/r/72728/#comment310832>
I think we should swap these two lines and add a newline between them.
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 95 (patched)
<https://reviews.apache.org/r/72728/#comment310833>
This one seems unused.
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 132-133 (patched)
<https://reviews.apache.org/r/72728/#comment310834>
A newline between, or we could just swap these two lines.
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 238 (patched)
<https://reviews.apache.org/r/72728/#comment310835>
Do we really need this method? I see it is only called when we create CSI server in `ROOT_PluginConfigAddedAtRuntime`, can we just create the CSI server with NULL secret generator like what we do in `ROOT_InvalidPluginConfig`?
src/tests/containerizer/volume_csi_isolator_tests.cpp
Lines 794 (patched)
<https://reviews.apache.org/r/72728/#comment310836>
Usually we use `SUDO_USER` as the non-root user in our unit tests, see https://github.com/apache/mesos/blob/1.10.0/src/tests/containerizer/docker_volume_isolator_tests.cpp#L1335 . And the test name should have the `UNPRIVILEGED_USER_` prefix.
Just realized in a couple of your tests here, we need to pull Docker image `alpine` from Docker Hub, right? Then I think we need to include the prefix `INTERNET_CURL_` in the test name.
- Qian Zhang
On Sept. 2, 2020, 1:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2020, 1:57 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/13/
>
>
> Testing
> -------
>
> `sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Sept. 2, 2020, 5:57 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Added tests for the 'volume/csi' isolator.
Diffs
-----
src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63
src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/13/
Testing (updated)
-------
`sudo bin/mesos-tests.sh --gtest_filter="*VolumeCSIIsolatorTest*"`
Thanks,
Greg Mann
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Sept. 2, 2020, 5:52 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Added tests for the 'volume/csi' isolator.
Diffs (updated)
-----
src/Makefile.am 1043c7b860372a17dba1e84fe5547388cb6a3b63
src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/13/
Changes: https://reviews.apache.org/r/72728/diff/12-13/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 29, 2020, 12:47 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Added tests for the 'volume/csi' isolator.
Diffs (updated)
-----
src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/12/
Changes: https://reviews.apache.org/r/72728/diff/11-12/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 26, 2020, 6:12 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Added tests for the 'volume/csi' isolator.
Diffs (updated)
-----
src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/11/
Changes: https://reviews.apache.org/r/72728/diff/10-11/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221716
-----------------------------------------------------------
Bad patch!
Reviews applied: [72728, 72805, 72727, 72726, 72754, 72753, 72734, 72733, 72690, 72716, 72732]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72727
Error:
2020-08-26 08:09:06 URL:https://reviews.apache.org/r/72727/diff/raw/ [7515/7515] -> "72727.patch" [1]
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <je...@asf931.gq1.ygridcore.net>) not allowed
Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/119/console
- Mesos Reviewbot
On Aug. 26, 2020, 1:57 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2020, 1:57 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added tests for the 'volume/csi' isolator.
>
>
> Diffs
> -----
>
> src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
> src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
> src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
> src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/10/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added tests for the 'volume/csi' isolator.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 26, 2020, 5:57 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Summary (updated)
-----------------
Added tests for the 'volume/csi' isolator.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description (updated)
-------
Added tests for the 'volume/csi' isolator.
Diffs (updated)
-----
src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
src/tests/CMakeLists.txt 6b420d03e85470c16de85c1cbb81ec339142e226
src/tests/cluster.cpp 3c8685565f9de6c314f6be758368f1eff46e2370
src/tests/containerizer/volume_csi_isolator_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/10/
Changes: https://reviews.apache.org/r/72728/diff/9-10/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added unit tests for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 24, 2020, 9:20 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Added unit tests for the CSI server.
Diffs
-----
src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/9/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added unit tests for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 21, 2020, 4:34 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Added unit tests for the CSI server.
Diffs (updated)
-----
src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/9/
Changes: https://reviews.apache.org/r/72728/diff/8-9/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added unit tests for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 21, 2020, 2:20 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
Added unit tests for the CSI server.
Diffs (updated)
-----
src/Makefile.am 8b95611baff2f925910ea46addf462cf9f33071b
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/8/
Changes: https://reviews.apache.org/r/72728/diff/7-8/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added unit tests for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 19, 2020, 9:50 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Summary (updated)
-----------------
Added unit tests for the CSI server.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description (updated)
-------
Added unit tests for the CSI server.
Diffs (updated)
-----
src/Makefile.am 6d68ed050f99889c142d49bbc72a9292ef64c836
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/7/
Changes: https://reviews.apache.org/r/72728/diff/6-7/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 19, 2020, 6:18 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs (updated)
-----
src/Makefile.am 6d68ed050f99889c142d49bbc72a9292ef64c836
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/6/
Changes: https://reviews.apache.org/r/72728/diff/5-6/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 18, 2020, 1:27 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs (updated)
-----
src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/5/
Changes: https://reviews.apache.org/r/72728/diff/4-5/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221564
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72732, 72716, 72690, 72733, 72734, 72753, 72754, 72726, 72727, 72761, 72728]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Aug. 13, 2020, 2:38 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2020, 2:38 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/4/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 13, 2020, 2:38 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs
-----
src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/4/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 13, 2020, 2:36 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs
-----
src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/4/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 12, 2020, 7:21 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs
-----
src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/4/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 12, 2020, 7:20 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs
-----
src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/4/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 12, 2020, 7:13 p.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs (updated)
-----
src/Makefile.am 49dab4b6488b75d32e6ee9d54d68afe36549c353
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/4/
Changes: https://reviews.apache.org/r/72728/diff/3-4/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221550
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72732, 72716, 72726, 72727, 72728]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On Aug. 11, 2020, 3:08 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2020, 3:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/3/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221538
-----------------------------------------------------------
Bad patch!
Reviews applied: [72732, 72716, 72726, 72727, 72728]
Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh 2>&1 | tee build_72728"]
Error:
ubuntu-16.04: Pulling from mesos/mesos-build
18d680d61657: Pulling fs layer
0addb6fece63: Pulling fs layer
78e58219b215: Pulling fs layer
eb6959a66df2: Pulling fs layer
1105027a5560: Pulling fs layer
c36946130a38: Pulling fs layer
6a6a5e68faab: Pulling fs layer
80e07249924c: Pulling fs layer
c4c63e2501db: Pulling fs layer
668b207c2829: Pulling fs layer
ed76dddad568: Pulling fs layer
eb6959a66df2: Waiting
1105027a5560: Waiting
c36946130a38: Waiting
6a6a5e68faab: Waiting
80e07249924c: Waiting
c4c63e2501db: Waiting
668b207c2829: Waiting
ed76dddad568: Waiting
78e58219b215: Verifying Checksum
78e58219b215: Download complete
0addb6fece63: Verifying Checksum
0addb6fece63: Download complete
eb6959a66df2: Verifying Checksum
eb6959a66df2: Download complete
18d680d61657: Verifying Checksum
18d680d61657: Download complete
c36946130a38: Download complete
6a6a5e68faab: Verifying Checksum
6a6a5e68faab: Download complete
80e07249924c: Verifying Checksum
80e07249924c: Download complete
c4c63e2501db: Verifying Checksum
c4c63e2501db: Download complete
668b207c2829: Verifying Checksum
668b207c2829: Download complete
ed76dddad568: Verifying Checksum
ed76dddad568: Download complete
1105027a5560: Verifying Checksum
1105027a5560: Download complete
18d680d61657: Pull complete
0addb6fece63: Pull complete
78e58219b215: Pull complete
eb6959a66df2: Pull complete
1105027a5560: Pull complete
c36946130a38: Pull complete
6a6a5e68faab: Pull complete
80e07249924c: Pull complete
c4c63e2501db: Pull complete
668b207c2829: Pull complete
ed76dddad568: Pull complete
Digest: sha256:fa967cbcfb44f55708a3cbc87f245c6d29dd891464db558af56a03ee321526bb
Status: Downloaded newer image for mesos/mesos-build:ubuntu-16.04
docker.io/mesos/mesos-build:ubuntu-16.04
Cloning into '/tmp/SRC'...
Note: checking out '95b926d9bb565afd8235479f4b67a0777e3209f3'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:
git checkout -b <new-branch-name>
autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --warnings=all -I m4
autoreconf: configure.ac: tracing
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: running: libtoolize --copy
libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
libtoolize: copying file 'm4/libtool.m4'
libtoolize: copying file 'm4/ltoptions.m4'
libtoolize: copying file 'm4/ltsugar.m4'
libtoolize: copying file 'm4/ltversion.m4'
libtoolize: copying file 'm4/lt~obsolete.m4'
autoreconf: running: /usr/bin/autoconf --warnings=all
configure.ac:1873: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1873: the top level
configure.ac:1878: warning: cannot check for file existence when cross compiling
../../lib/autoconf/general.m4:2788: AC_CHECK_FILE is expanded from...
configure.ac:1878: the top level
configure.ac:2399: warning: AC_RUN_IFELSE called without default to allow cross compiling
../../lib/autoconf/general.m4:2759: AC_RUN_IFELSE is expanded from...
configure.ac:2399: the top level
autoreconf: configure.ac: not using Autoheader
autoreconf: running: automake --add-missing --copy --no-force --warnings=all
configure.ac:50: installing './ar-lib'
configure.ac:34: installing './compile'
configure.ac:24: installing './config.guess'
configure.ac:24: installing './config.sub'
configure.ac:46: installing './install-sh'
configure.ac:46: installing './missing'
3rdparty/Makefile.am:307: warning: source file '$(HTTP_PARSER)/http_parser.c' is in a subdirectory,
3rdparty/Makefile.am:307: but option 'subdir-objects' is disabled
automake: warning: possible forward-incompatibility.
automake: At least a source file is in a subdirectory, but the 'subdir-objects'
automake: automake option hasn't been enabled. For now, the corresponding output
automake: object file(s) will be placed in the top-level directory. However,
automake: this behaviour will change in future Automake versions: they will
automake: unconditionally cause object files to be placed in the same subdirectory
automake: of the corresponding sources.
automake: You are advised to start using 'subdir-objects' option throughout your
automake: project, to avoid future incompatibilities.
3rdparty/Makefile.am: installing './depcomp'
3rdparty/Makefile.am:262: warning: variable 'GLOG_LDFLAGS' is defined but no program or
3rdparty/Makefile.am:262: library has 'GLOG' as canonical name (possible typo)
3rdparty/stout/Makefile.am:138: warning: source file 'tests/adaptor_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/archiver_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/base64_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/bits_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/boundedhashmap_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/bytes_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/cache_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/cpp17_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/duration_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/dynamiclibrary_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/error_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/flags_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/gzip_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/hashmap_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/hashset_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/interval_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/ip_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/json_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/jsonify_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/lambda_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/linkedhashmap_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/mac_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/main.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/multimap_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/none_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/numify_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/option_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/copyfile_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/env_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/filesystem_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/process_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/rmdir_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/sendfile_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/signals_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/socket_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/strerror_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/os/systems_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/path_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/protobuf_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/recordio_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/result_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/some_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/strings_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/subcommand_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/svn_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/try_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/uri_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/uuid_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/variant_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:138: warning: source file 'tests/version_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:138: but option 'subdir-objects' is disabled
3rdparty/stout/Makefile.am:193: warning: source file 'tests/proc_tests.cpp' is in a subdirectory,
3rdparty/stout/Makefile.am:193: but option 'subdir-objects' is disabled
autoreconf: Leaving directory `.'
checking build system type... x86_64-pc-linux-gnu
checking host system type... x86_64-pc-linux-gnu
checking target system type... x86_64-pc-linux-gnu
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking whether ln -s works... yes
checking for C++ compiler vendor... gnu
checking for a sed that does not truncate output... /bin/sed
checking for C++ compiler version... 5.4.0
checking for C++ compiler vendor... (cached) gnu
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... /bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking for style of include used by make... GNU
checking whether make supports nested variables... yes
checking how to create a pax tar archive... gnutar
checking dependency style of gcc... gcc3
checking dependency style of g++... gcc3
checking whether to enable maintainer-specific portions of Makefiles... yes
checking for ar... ar
checking the archiver (ar) interface... ar
checking how to print strings... printf
checking for a sed that does not truncate output... (cached) /bin/sed
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking for fgrep... /bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for archiver @FILE support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for a working dd... /bin/dd
checking how to truncate binary pipes... /bin/dd bs=4096 count=1
checking for mt... no
checking if : is a manifest tool... no
checking how to run the C preprocessor... gcc -E
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... no
checking how to run the C++ preprocessor... g++ -E
checking for ld used by g++... /usr/bin/ld -m elf_x86_64
checking if the linker (/usr/bin/ld -m elf_x86_64) is GNU ld... yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking for g++ option to produce PIC... -fPIC -DPIC
checking if g++ PIC flag -fPIC -DPIC works... yes
checking if g++ static flag -static works... yes
checking if g++ supports -c -o file.o... yes
checking if g++ supports -c -o file.o... (cached) yes
checking whether the g++ linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking dynamic linker characteristics... (cached) GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
configure: creating ./config.lt
config.lt: creating libtool
checking whether to enable GC of unused sections... no
configure: Setting up CXXFLAGS for g++ version >= 4.8
checking whether C++ compiler accepts -fstack-protector-strong... yes
checking whether g++ supports C++11 features by default... no
checking whether g++ supports C++11 features with -std=c++11... yes
checking if compiler needs -Werror to reject unknown flags... no
checking for the pthreads library -lpthreads... no
checking whether pthreads work without any flags... no
checking whether pthreads work with -Kthread... no
checking whether pthreads work with -kthread... no
checking for the pthreads library -llthread... no
checking whether pthreads work with -pthread... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking if more special flags are required for pthreads... no
checking for PTHREAD_PRIO_INHERIT... yes
configure: Setting up build environment for x86_64 linux-gnu
checking for backtrace in -lunwind... no
checking for RAND_poll in -lcrypto... yes
checking openssl/ssl.h usability... yes
checking openssl/ssl.h presence... yes
checking for openssl/ssl.h... yes
checking for SSL_CTX_new in -lssl... yes
checking for main in -lgflags... no
checking for patch... patch
checking fts.h usability... yes
checking fts.h presence... yes
checking for fts.h... yes
checking for library containing fts_close... none required
checking apr_pools.h usability... yes
checking apr_pools.h presence... yes
checking for apr_pools.h... yes
checking for apr_initialize in -lapr-1... yes
checking for curl_global_init in -lcurl... yes
checking for javac... /usr/bin/javac
checking for java... /usr/bin/java
checking value of Java system property 'java.home'... /usr/lib/jvm/java-8-openjdk-amd64/jre
configure: using JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
checking whether or not we can build with JNI... yes
checking for mvn... /usr/bin/mvn
checking for javah... /usr/lib/jvm/java-8-openjdk-amd64/bin/javah
checking whether to enable launcher sealing... no
checking whether to enable the Seccomp isolator... no
checking for sasl_done in -lsasl2... yes
checking SASL CRAM-MD5 support... yes
checking svn_version.h usability... yes
checking svn_version.h presence... yes
checking for svn_version.h... yes
checking for svn_stringbuf_create_ensure in -lsvn_subr-1... yes
checking svn_delta.h usability... yes
checking svn_delta.h presence... yes
checking for svn_delta.h... yes
checking for svn_txdelta in -lsvn_delta-1... yes
checking whether to enable the XFS disk isolator... no
checking zlib.h usability... yes
checking zlib.h presence... yes
checking for zlib.h... yes
checking for deflate, gzread, gzwrite, inflate in -lz... yes
checking C++ standard library for undefined behaviour with selected optimization level... no
checking for python... /usr/bin/python
checking for python version... 2.7
checking for python platform... linux2
checking for python script directory... ${prefix}/lib/python2.7/dist-packages
checking for python extension module directory... ${exec_prefix}/lib/python2.7/dist-packages
checking for python2.7... (cached) /usr/bin/python
checking for a version of Python >= '2.1.0'... yes
checking for a version of Python >= '2.6'... yes
checking for the distutils Python package... yes
checking for Python include path... -I/usr/include/python2.7
checking for Python library path... -L/usr/lib -lpython2.7
checking for Python site-packages path... /usr/lib/python2.7/dist-packages
checking python extra libraries... -lpthread -ldl -lutil -lm
checking python extra linking flags... -Xlinker -export-dynamic -Wl,-O1 -Wl,-Bsymbolic-functions
checking consistency of all components of python development environment... yes
checking whether we can build usable Python eggs... cc1plus: warning: command line option '-Wstrict-prototypes' is valid for C/ObjC but not for C++
yes
checking for an old installation of the Mesos egg (before 0.20.0)... no
checking whether to enable new CLI... no
checking src/common/git_version.hpp presence... no
configure: generating src/common/git_version.hpp
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating mesos.pc
config.status: creating src/Makefile
config.status: creating 3rdparty/Makefile
config.status: creating 3rdparty/libprocess/Makefile
config.status: creating 3rdparty/libprocess/include/Makefile
config.status: creating 3rdparty/stout/Makefile
config.status: creating 3rdparty/stout/include/Makefile
config.status: creating 3rdparty/gmock_sources.cc
config.status: creating bin/mesos.sh
config.status: creating bin/mesos-agent.sh
config.status: creating bin/mesos-local.sh
config.status: creating bin/mesos-master.sh
config.status: creating bin/mesos-slave.sh
config.status: creating bin/mesos-tests.sh
config.status: creating bin/mesos-agent-flags.sh
config.status: creating bin/mesos-local-flags.sh
config.status: creating bin/mesos-master-flags.sh
config.status: creating bin/mesos-slave-flags.sh
config.status: creating bin/mesos-tests-flags.sh
config.status: creating bin/gdb-mesos-agent.sh
config.status: creating bin/gdb-mesos-local.sh
config.status: creating bin/gdb-mesos-master.sh
config.status: creating bin/gdb-mesos-slave.sh
config.status: creating bin/gdb-mesos-tests.sh
config.status: creating bin/lldb-mesos-agent.sh
config.status: creating bin/lldb-mesos-local.sh
config.status: creating bin/lldb-mesos-master.sh
config.status: creating bin/lldb-mesos-slave.sh
config.status: creating bin/lldb-mesos-tests.sh
config.status: creating bin/valgrind-mesos-agent.sh
config.status: creating bin/valgrind-mesos-local.sh
config.status: creating bin/valgrind-mesos-master.sh
config.status: creating bin/valgrind-mesos-slave.sh
config.status: creating bin/valgrind-mesos-tests.sh
config.status: creating src/deploy/mesos-daemon.sh
config.status: creating src/deploy/mesos-start-agents.sh
config.status: creating src/deploy/mesos-start-cluster.sh
config.status: creating src/deploy/mesos-start-masters.sh
config.status: creating src/deploy/mesos-start-slaves.sh
config.status: creating src/deploy/mesos-stop-agents.sh
config.status: creating src/deploy/mesos-stop-cluster.sh
config.status: creating src/deploy/mesos-stop-masters.sh
config.status: creating src/deploy/mesos-stop-slaves.sh
config.status: creating include/mesos/version.hpp
config.status: creating src/java/generated/org/apache/mesos/MesosNativeLibrary.java
config.status: creating src/examples/java/test-exception-framework
config.status: creating src/examples/java/test-executor
config.status: creating src/examples/java/test-framework
config.status: creating src/examples/java/test-multiple-executors-framework
config.status: creating src/examples/java/test-log
config.status: creating src/examples/java/v1-test-framework
config.status: creating src/java/mesos.pom
config.status: creating src/examples/python/test-executor
config.status: creating src/examples/python/test-framework
config.status: creating src/python/setup.py
config.status: creating src/python/cli/setup.py
config.status: creating src/python/interface/setup.py
config.status: creating src/python/native_common/ext_modules.py
config.status: creating src/python/executor/setup.py
config.status: creating src/python/native/setup.py
config.status: creating src/python/scheduler/setup.py
config.status: creating src/common/git_version.hpp
config.status: linking src/python/native_common/ext_modules.py to src/python/executor/ext_modules.py
config.status: linking src/python/native_common/ext_modules.py to src/python/scheduler/ext_modules.py
config.status: executing depfiles commands
config.status: executing libtool commands
configure: Build option summary:
CXX: g++
CXXFLAGS: -g1 -O0 -Wno-unused-local-typedefs -std=c++11
CPPFLAGS: -I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0
LDFLAGS:
LIBS: -lz -lsvn_delta-1 -lsvn_subr-1 -lsasl2 -lcurl -lapr-1 -lrt
JAVA_TEST_LDFLAGS: -L/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server -R/usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server -Wl,-ljvm
JAVA_JVM_LIBRARY: /usr/lib/jvm/java-8-openjdk-amd64/jre/lib/amd64/server/libjvm.so
make dist-gzip am__post_remove_distdir='@:'
make[1]: Entering directory '/tmp/SRC/build'
if test -d "mesos-1.11.0"; then find "mesos-1.11.0" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -rf "mesos-1.11.0" || { sleep 5 && rm -rf "mesos-1.11.0"; }; else :; fi
test -d "mesos-1.11.0" || mkdir "mesos-1.11.0"
(cd 3rdparty && make top_distdir=../mesos-1.11.0 distdir=../mesos-1.11.0/3rdparty \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory '/tmp/SRC/build/3rdparty'
(cd stout && make top_distdir=../../mesos-1.11.0 distdir=../../mesos-1.11.0/3rdparty/stout \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/tmp/SRC/build/3rdparty/stout'
(cd include && make top_distdir=../../../mesos-1.11.0 distdir=../../../mesos-1.11.0/3rdparty/stout/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory '/tmp/SRC/build/3rdparty/stout/include'
make[4]: Leaving directory '/tmp/SRC/build/3rdparty/stout/include'
make \
top_distdir="../../mesos-1.11.0" distdir="../../mesos-1.11.0/3rdparty/stout" \
dist-hook
make[4]: Entering directory '/tmp/SRC/build/3rdparty/stout'
cp -r ../../../3rdparty/stout/3rdparty ../../mesos-1.11.0/3rdparty/stout/
make[4]: Leaving directory '/tmp/SRC/build/3rdparty/stout'
make[3]: Leaving directory '/tmp/SRC/build/3rdparty/stout'
(cd libprocess && make top_distdir=../../mesos-1.11.0 distdir=../../mesos-1.11.0/3rdparty/libprocess \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[3]: Entering directory '/tmp/SRC/build/3rdparty/libprocess'
(cd include && make top_distdir=../../../mesos-1.11.0 distdir=../../../mesos-1.11.0/3rdparty/libprocess/include \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[4]: Entering directory '/tmp/SRC/build/3rdparty/libprocess/include'
make[4]: Leaving directory '/tmp/SRC/build/3rdparty/libprocess/include'
make \
top_distdir="../../mesos-1.11.0" distdir="../../mesos-1.11.0/3rdparty/libprocess" \
dist-hook
make[4]: Entering directory '/tmp/SRC/build/3rdparty/libprocess'
cp -r ../../../3rdparty/libprocess/3rdparty ../../mesos-1.11.0/3rdparty/libprocess/
make[4]: Leaving directory '/tmp/SRC/build/3rdparty/libprocess'
make[3]: Leaving directory '/tmp/SRC/build/3rdparty/libprocess'
make[2]: Leaving directory '/tmp/SRC/build/3rdparty'
(cd src && make top_distdir=../mesos-1.11.0 distdir=../mesos-1.11.0/src \
am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir)
make[2]: Entering directory '/tmp/SRC/build/src'
../3rdparty/protobuf-3.5.0/src/protoc -I../../include -I../../src -I../3rdparty/csi-0.2.0 -I../3rdparty/csi-1.1.0 -I../3rdparty/protobuf-3.5.0/src --cpp_out=. ../../src/tests/common/http_tests.proto
/bin/bash: ../3rdparty/protobuf-3.5.0/src/protoc: No such file or directory
Makefile:15608: recipe for target 'tests/common/http_tests.pb.cc' failed
make[2]: *** [tests/common/http_tests.pb.cc] Error 127
make[2]: Leaving directory '/tmp/SRC/build/src'
Makefile:885: recipe for target 'distdir' failed
make[1]: *** [distdir] Error 1
make[1]: Leaving directory '/tmp/SRC/build'
Makefile:984: recipe for target 'dist' failed
make: *** [dist] Error 2
Untagged: mesos/mesos-build:ubuntu-16.04
Untagged: mesos/mesos-build@sha256:fa967cbcfb44f55708a3cbc87f245c6d29dd891464db558af56a03ee321526bb
Deleted: sha256:e895c0531b9a9a288fabe479a49f7059aed83645351ac99ec2ea2616822c9f97
Deleted: sha256:09119b0b314a69ba6ec6251f2e89f4199fe1e874c84f9abf07dcbd23dbc3f1c1
Deleted: sha256:562fe6af5a3883058be9c784a839392215ed4185a21d21f1d99df0d17f3ae6e7
Deleted: sha256:0dcdfbe322a4f332f73ac70905d557300ec6dae3bd19586758772c750c7b4a19
Deleted: sha256:c66652d605f01094e2db53d62505dbd524e076d5aa69b89d5e620003803eb149
Deleted: sha256:a2cf79bfb9593c05fd7142ddb49afef77ea4ad5d2464e841f09fe62ffee396e0
Deleted: sha256:f7a904214b390f39d98573882f631dc908df8b2b540cf04e1062f8182c1efffd
Deleted: sha256:ce1f6fcaa83dfce189d76e08f184085732eab4eeb2562d2399953958405c5bec
Deleted: sha256:cce92fda689ab9033f0b8db214bc63edd1ae3e05831a0f3a9418976d7dc7ccdd
Deleted: sha256:d22094bbd65447c59a42c580eaa3a44cee9cd855f00905f59409be21bcefc745
Deleted: sha256:b8976847450013f3eb5e9a81a5778f73ed7bef67e6393049712ef17102b4b7b7
Deleted: sha256:b8c891f0ffec910a12757d733b178e3f62d81dbbde2b31d3b754071c416108ed
Error response from daemon: conflict: unable to delete 52c525da2c0e (cannot be forced) - image is being used by running container fb4ae15ba249
Full log: https://builds.apache.org/job/Mesos-Reviewbot-Linux/11833/console
- Mesos Reviewbot
On Aug. 11, 2020, 3:08 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2020, 3:08 a.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/3/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 11, 2020, 3:08 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs (updated)
-----
src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/3/
Changes: https://reviews.apache.org/r/72728/diff/2-3/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221523
-----------------------------------------------------------
src/Makefile.am
Lines 2831 (patched)
<https://reviews.apache.org/r/72728/#comment310571>
It seems we need 3 more tabs between `csi_server_tests.cpp` and ``.
src/tests/csi_server_tests.cpp
Lines 22-23 (patched)
<https://reviews.apache.org/r/72728/#comment310572>
These two lines should be put above the line `#include <mesos/master/detector.hpp>`.
src/tests/csi_server_tests.cpp
Lines 92 (patched)
<https://reviews.apache.org/r/72728/#comment310573>
I do not see how `slaveWorkDirs` is used afterward.
- Qian Zhang
On Aug. 7, 2020, 3:02 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2020, 3:02 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/2/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/
-----------------------------------------------------------
(Updated Aug. 7, 2020, 7:02 a.m.)
Review request for mesos, Andrei Budnik and Qian Zhang.
Bugs: MESOS-10163
https://issues.apache.org/jira/browse/MESOS-10163
Repository: mesos
Description
-------
The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
the CSI server can load a plugin and execute publish and
unpublish calls against it.
Diffs (updated)
-----
src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89
src/tests/csi_server_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72728/diff/2/
Changes: https://reviews.apache.org/r/72728/diff/1-2/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221454
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72660, 72661, 72672, 72681, 72715, 72707, 72716, 72726, 72727, 72728]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On July 31, 2020, 7:09 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated July 31, 2020, 7:09 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/1/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 72728: Added a unit test for the CSI server.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72728/#review221442
-----------------------------------------------------------
Patch looks great!
Reviews applied: [72660, 72661, 72672, 72681, 72715, 72707, 72716, 72726, 72727, 72728]
Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh
- Mesos Reviewbot
On July 31, 2020, 7:09 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72728/
> -----------------------------------------------------------
>
> (Updated July 31, 2020, 7:09 p.m.)
>
>
> Review request for mesos, Andrei Budnik and Qian Zhang.
>
>
> Bugs: MESOS-10163
> https://issues.apache.org/jira/browse/MESOS-10163
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new test 'CSIServerTest.ROOT_LoadPlugin' verifies that
> the CSI server can load a plugin and execute publish and
> unpublish calls against it.
>
>
> Diffs
> -----
>
> src/Makefile.am a89919dd7d5ccbc4c5fa79d9a83616608f84ef49
> src/tests/csi_server_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72728/diff/1/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>