You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/10/25 20:58:33 UTC
[kudu-CR](branch-1.8.x) [doc] run doxygen with no warnings
Hello Kudu Jenkins, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/11792
to review the following change.
Change subject: [doc] run doxygen with no warnings
......................................................................
[doc] run doxygen with no warnings
Updated doxygen configuration due to recent changes in Kudu C++ client
sample application. Cleaned up other minor documentation issues
in src/kudu/client/schema.h. With this patch, doxygen runs without any
warnings while auto-generating documentation for Kudu C++ client API
(verified with doxygen 1.8.14 built on OS X 10.11.6).
This is a follow-up for a30c9211e8e73ead70acdb6108e5a0eac90cb5cb.
Change-Id: Iedb31849288caa59456aff6eb075cf23c843d4e0
Reviewed-on: http://gerrit.cloudera.org:8080/11784
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 9042eda2c6c055c364f9c441c9b7fab3ecd15649)
---
M CMakeLists.txt
M docs/support/doxygen/client_api.doxy.in
M src/kudu/client/schema.h
3 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/92/11792/1
--
To view, visit http://gerrit.cloudera.org:8080/11792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iedb31849288caa59456aff6eb075cf23c843d4e0
Gerrit-Change-Number: 11792
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.8.x) [doc] run doxygen with no warnings
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/11792 )
Change subject: [doc] run doxygen with no warnings
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iedb31849288caa59456aff6eb075cf23c843d4e0
Gerrit-Change-Number: 11792
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Oct 2018 23:17:33 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.8.x) [doc] run doxygen with no warnings
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11792 )
Change subject: [doc] run doxygen with no warnings
......................................................................
[doc] run doxygen with no warnings
Updated doxygen configuration due to recent changes in Kudu C++ client
sample application. Cleaned up other minor documentation issues
in src/kudu/client/schema.h. With this patch, doxygen runs without any
warnings while auto-generating documentation for Kudu C++ client API
(verified with doxygen 1.8.14 built on OS X 10.11.6).
This is a follow-up for a30c9211e8e73ead70acdb6108e5a0eac90cb5cb.
Change-Id: Iedb31849288caa59456aff6eb075cf23c843d4e0
Reviewed-on: http://gerrit.cloudera.org:8080/11784
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
(cherry picked from commit 9042eda2c6c055c364f9c441c9b7fab3ecd15649)
Reviewed-on: http://gerrit.cloudera.org:8080/11792
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M CMakeLists.txt
M docs/support/doxygen/client_api.doxy.in
M src/kudu/client/schema.h
3 files changed, 10 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.8.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Iedb31849288caa59456aff6eb075cf23c843d4e0
Gerrit-Change-Number: 11792
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)