You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/08/06 03:53:31 UTC
[GitHub] [rocketmq-streams] RongtongJin opened a new pull request #13: Add apache-rat check plugin and add apache license
RongtongJin opened a new pull request #13:
URL: https://github.com/apache/rocketmq-streams/pull/13
Add apache-rat check plugin and some file add apache license
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] vongosling commented on pull request #13: Add apache-rat check plugin and add apache license
Posted by GitBox <gi...@apache.org>.
vongosling commented on pull request #13:
URL: https://github.com/apache/rocketmq-streams/pull/13#issuecomment-894049889
There are many points should be optimize before we call for a fomal package. such as , logging system are confusing, do not import log4j, commons-logging; many depdendency scope are missing, such as junit. scala?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] duhenglucky merged pull request #13: Add apache-rat check plugin and add apache license
Posted by GitBox <gi...@apache.org>.
duhenglucky merged pull request #13:
URL: https://github.com/apache/rocketmq-streams/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-streams] vongosling edited a comment on pull request #13: Add apache-rat check plugin and add apache license
Posted by GitBox <gi...@apache.org>.
vongosling edited a comment on pull request #13:
URL: https://github.com/apache/rocketmq-streams/pull/13#issuecomment-894049889
There are many points that should be optimized before we call for a formal package. such as logging system are confusing, do not import log4j, commons-logging; many dependencies scopes is missing, such as JUnit. scala, jpython, groovy; so many json parser, gson, fastjson; and so many 3rd notices should be mentioned, such as MySQL driver?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org