[GitHub] [iotdb] ericpai commented on a diff in pull request #7060: [IOTDB-4174] Show RegionNum when show storagegroup

[GitBox <gi...@apache.org>]

ericpai commented on code in PR #7060:
URL: https://github.com/apache/iotdb/pull/7060#discussion_r949924120


##########
confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java:
##########
@@ -202,7 +202,7 @@ public StorageGroupSchemaResp getMatchedStorageGroupSchemas(GetStorageGroupPlan
       LOGGER.error("Error StorageGroup name", e);
       result.setStatus(
           new TSStatus(TSStatusCode.STORAGE_GROUP_NOT_EXIST.getStatusCode())
-              .setMessage("Error StorageGroup name"));
+              .setMessage("Error StorageGroup name: " + e));

Review Comment:
   `+ e.getMessage()`? I think `getMessage()` is more friendly for human read.



##########
confignode/src/main/java/org/apache/iotdb/confignode/service/thrift/ConfigNodeRPCServiceProcessor.java:
##########
@@ -568,9 +567,13 @@ public TShowConfigNodesResp showConfigNodes() throws TException {
     return configManager.showConfigNodes();
   }
 
-  public void handleClientExit() {}
+  @Override
+  public TShowStorageGroupResp showStorageGroup(List<String> storageGroupPathPattern)
+      throws TException {
+    return configManager.showStorageGroup(new GetStorageGroupPlan(storageGroupPathPattern));
+  }
 
-  // TODO: Interfaces for data operations
+  public void handleClientExit() {}

Review Comment:
   What's this empty method used for?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org