[jira] Commented: (TUSCANY-2058) The method XSDHelper.isXSD(Type) is returning invalid information

["Kelvin Goodson (JIRA)" <tu...@ws.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12575016#action_12575016 ] 

Kelvin Goodson commented on TUSCANY-2058:
-----------------------------------------

This makes me wonder whether the spec has been a bit loose in its wording here and missed an opportunity.  We keep our annotations that carry this extra metadata on the Type instance itself, so every xsdHelper would have access to the infomation.  I think it's worth opening this up as a spec issue. 

the actual contents of the Spec do not completely preclude the behaviour we are seeing ...

"IsXSD() can be used to tell if the XSDHelper has information about a Type." -- and,  for the duration of the isXSD(method), it does,  by virtue of the supplied argument.

It's the JavaDoc that's the main issue.  It says ...

Indicates if this helper contains XSD information for the specified type.

Which again is very loose, and probably wrong, since a set of helpers congregate around a scope for Types,  so an xsdHelper would have access to types that had been defined by itself,  and by the TypeHelper belonging to that scope.  Hence the fact that is has information about that type is not the discriminator that determines the return value.

I would suggest the behaviour we are seeing is the logical behaviour.

> The method XSDHelper.isXSD(Type) is returning invalid information
> -----------------------------------------------------------------
>
>                 Key: TUSCANY-2058
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-2058
>             Project: Tuscany
>          Issue Type: Bug
>          Components: Java SDO Implementation
>    Affects Versions: Java-SDO-1.0
>         Environment: n/a
>            Reporter: David T. Adcox
>             Fix For: Java-SDO-Next
>
>         Attachments: Test2058.java
>
>
> Based on my understanding, XSDHelper.isXSD(Type) should return 'true' if the supplied Type object has been defined in the Scope from which the XSDHelper was constructed.  In turn, I expect that 'false' will be returned, for a Type object NOT defined in the Scope.  In some testing I have performed, I'm seeing that 'true' is always returned, even if the Type is defined outside the Scope being questioned.  I will attach a sample.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org