You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2023/06/02 22:36:22 UTC
[GitHub] [parquet-mr] yihua opened a new pull request, #1104: PARQUET-2301 (parquet-1.13.x branch): Add missing argument in ParquetRewriter logging
yihua opened a new pull request, #1104:
URL: https://github.com/apache/parquet-mr/pull/1104
Cherry-pick #1096 to `parquet-1.13.x` branch.
### Jira
- [x] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title: https://issues.apache.org/jira/browse/PARQUET-2301
### Tests
- [x] Already covered by existing tests in `ParquetRewriterTest`
Before this PR, the logging message puts the output path directly after `input files`, which is confusing:
```
2023-05-24 17:25:49 INFO ParquetRewriter - Start rewriting 1 input files /var/folders/60/wk8qzx310fd32b2dp7mhzvdc0000gn/T/test6036085754599645014/test.parquet to {}
```
After this PR, the log is fixed:
```
2023-05-24 17:22:16 INFO ParquetRewriter - Start rewriting 1 input file(s) [/var/folders/60/wk8qzx310fd32b2dp7mhzvdc0000gn/T/test1323432776204209385/test.parquet] to /var/folders/60/wk8qzx310fd32b2dp7mhzvdc0000gn/T/test6904487786327536358/test.parquet
```
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] No documentation needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-mr] wgtmac merged pull request #1104: PARQUET-2301 (parquet-1.13.x branch): Add missing argument in ParquetRewriter logging
Posted by "wgtmac (via GitHub)" <gi...@apache.org>.
wgtmac merged PR #1104:
URL: https://github.com/apache/parquet-mr/pull/1104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org