You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/29 23:48:11 UTC

[GitHub] [beam] TheNeuralBit commented on a diff in pull request #17477: [BEAM-10265] Display error message if trying to infer recursive schema from POJO/Proto objects

TheNeuralBit commented on code in PR #17477:
URL: https://github.com/apache/beam/pull/17477#discussion_r862260115


##########
sdks/java/extensions/protobuf/src/main/java/org/apache/beam/sdk/extensions/protobuf/ProtoSchemaTranslator.java:
##########
@@ -126,6 +127,7 @@
  * </ul>
  */
 @SuppressWarnings({
+  "nullness", // TODO(https://issues.apache.org/jira/browse/BEAM-10402)

Review Comment:
   Could you address the null checker errors rather than suppressing it in this way? The goal of BEAM-10402 is to reduce the number of these suppressions over time :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org