You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/20 15:49:19 UTC

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #5282: Update board Make.defs

btashton commented on a change in pull request #5282:
URL: https://github.com/apache/incubator-nuttx/pull/5282#discussion_r788898266



##########
File path: boards/risc-v/bl602/bl602evb/scripts/Make.defs
##########
@@ -45,8 +45,8 @@ ifneq ($(CONFIG_DEBUG_NOOPT),y)
 endif
 
 ARCHCPUFLAGS += -mno-relax
-ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections -fstrict-volatile-bitfields -fshort-enums -fno-omit-frame-pointer
-ARCHCXXFLAGS = -fno-builtin -ffunction-sections -fdata-sections -fstrict-volatile-bitfields -fshort-enums -fno-omit-frame-pointer -fno-exceptions -fcheck-new -std=c++17 -D__NuttX__ -pipe -nostdinc++
+ARCHCFLAGS = -fno-builtin -ffunction-sections -fdata-sections

Review comment:
       @xiaoxiang781216 if I recall this was required for abi compatibility when calling some ROM functions which unfortunately used enums as part of the API.  I know this is the case also with the Nordic Bluetooth softcore as well.  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org