[GitHub] [arrow-datafusion] Dandandan commented on a diff in pull request #5939: Count distinct support multiple expressions

["Dandandan (via GitHub)" <gi...@apache.org>]

Dandandan commented on code in PR #5939:
URL: https://github.com/apache/arrow-datafusion/pull/5939#discussion_r1161791822


##########
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##########
@@ -30,30 +30,31 @@ use datafusion_common::ScalarValue;
 use datafusion_common::{DataFusionError, Result};
 use datafusion_expr::Accumulator;
 
-type DistinctScalarValues = ScalarValue;
+#[derive(Debug, PartialEq, Eq, Hash, Clone)]
+struct DistinctScalarValues(Vec<ScalarValue>);

Review Comment:
   The downside is some performance loss / increased memory usage for single expressions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org