You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@turbine.apache.org by tv...@apache.org on 2016/01/08 12:40:19 UTC
svn commit: r1723703 - in /turbine/core/trunk: conf/test/Log4j.properties
src/test/org/apache/turbine/modules/scheduledjobs/SimpleJob.java
Author: tv
Date: Fri Jan 8 11:40:19 2016
New Revision: 1723703
URL: http://svn.apache.org/viewvc?rev=1723703&view=rev
Log:
Make test run less chatty
Modified:
turbine/core/trunk/conf/test/Log4j.properties
turbine/core/trunk/src/test/org/apache/turbine/modules/scheduledjobs/SimpleJob.java
Modified: turbine/core/trunk/conf/test/Log4j.properties
URL: http://svn.apache.org/viewvc/turbine/core/trunk/conf/test/Log4j.properties?rev=1723703&r1=1723702&r2=1723703&view=diff
==============================================================================
--- turbine/core/trunk/conf/test/Log4j.properties (original)
+++ turbine/core/trunk/conf/test/Log4j.properties Fri Jan 8 11:40:19 2016
@@ -15,14 +15,22 @@
# specific language governing permissions and limitations
# under the License.
-log4j.rootLogger = DEBUG, log
+log4j.rootLogger = ERROR, logfile
+
+# Make sure that all isDebugEnabled() branches are hit during testing
+log4j.category.org.apache.turbine=DEBUG, logfile
# we want to see any errors thrown by Turbine.java, primarily in the handleException method
-log4j.category.org.apache.turbine.Turbine=DEBUG
+log4j.category.org.apache.turbine.Turbine=DEBUG, logfile
log4j.appender.log = org.apache.log4j.ConsoleAppender
log4j.appender.log.target = System.out
log4j.appender.log.layout = org.apache.log4j.PatternLayout
log4j.appender.log.layout.conversionPattern = %d [%t] %-5p %c - %m%n
+log4j.appender.logfile=org.apache.log4j.FileAppender
+log4j.appender.logfile.File=target/turbine.log
+log4j.appender.logfile.Append=false
+log4j.appender.logfile.layout=org.apache.log4j.PatternLayout
+log4j.appender.logfile.layout.conversionPattern = %d [%t] %-5p %c - %m%n
Modified: turbine/core/trunk/src/test/org/apache/turbine/modules/scheduledjobs/SimpleJob.java
URL: http://svn.apache.org/viewvc/turbine/core/trunk/src/test/org/apache/turbine/modules/scheduledjobs/SimpleJob.java?rev=1723703&r1=1723702&r2=1723703&view=diff
==============================================================================
--- turbine/core/trunk/src/test/org/apache/turbine/modules/scheduledjobs/SimpleJob.java (original)
+++ turbine/core/trunk/src/test/org/apache/turbine/modules/scheduledjobs/SimpleJob.java Fri Jan 8 11:40:19 2016
@@ -21,6 +21,8 @@ package org.apache.turbine.modules.sched
*/
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.turbine.modules.ScheduledJob;
import org.apache.turbine.services.schedule.JobEntry;
@@ -36,6 +38,9 @@ import org.apache.turbine.services.sched
public class SimpleJob
extends ScheduledJob
{
+ /** Logging */
+ private static Log log = LogFactory.getLog(SimpleJob.class);
+
/** The test counter */
private static int counter = 0;
@@ -45,13 +50,14 @@ public class SimpleJob
* @param job The job to run.
* @throws java.lang.Exception generic exception
*/
+ @Override
public void run(JobEntry job)
throws Exception
{
counter++;
- System.out.println("\n\nI AM RUNNING!\n\n");
-
+ log.info("I AM RUNNING!");
}
+
/**
* Returns the counter value.
*