[jira] Commented: (HADOOP-4365) Configuration.getProps() should be made protected for ease of overriding

["Doug Cutting (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654507#action_12654507 ] 

Doug Cutting commented on HADOOP-4365:
--------------------------------------

This needs some javadoc, but other than that seems fine.

Longer-term, should we replace 'new Configuration()' with a factory API?  Would that help you at all?  Or does that just move the problem?


> Configuration.getProps() should be made protected for ease of overriding
> ------------------------------------------------------------------------
>
>                 Key: HADOOP-4365
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4365
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 0.20.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>         Attachments: hadoop-4365.patch
>
>
> HADOOP-4293 does make Configuration cleaner and easier to work with, but it does contain assumptions about how configurations are represented (in a private Properties instance) that subclasses may wish to diverge from.
> By making getProps() protected, people who subclass JobConf or Configuration can do their own binding from configuration data to Properties. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.