You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2012/09/11 10:19:40 UTC
[Bug 120885] New: [From Symphony]Sample file's table border is
missing
https://issues.apache.org/ooo/show_bug.cgi?id=120885
Priority: P3
Bug ID: 120885
Assignee: ooo-issues@incubator.apache.org
Summary: [From Symphony]Sample file's table border is missing
Severity: normal
Issue Type: DEFECT
Classification: Application
OS: All
Reporter: yanji.yj@gmail.com
Hardware: All
Status: CONFIRMED
Version: AOO 3.4.0
Component: open-import
Product: presentation
Build: AOO 3.5 Trunk Rev r1381968
OS: All
Steps:
1. Open attached sample file
Defect: Table border is missing
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
--- Comment #7 from Ma Bingbing <ji...@gmail.com> ---
(In reply to comment #4)
> ALG: One question: Why not add the border properties directly to
> aFullPropertyMap_Impl and to potentially always have them? It's already done
> for e.g. SPECIAL_DIMENSIONING_PROPERTIES_DEFAULTS and should do no harm.
In my opinion, some style don't have border properties, so I add a new property
set for the style which has border.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
--- Comment #8 from Armin Le Grand <Ar...@me.com> ---
ALG: This is true, but also for the already added things like
CONNECTOR_PROPERTIES and SPECIAL_DIMENSIONING_PROPERTIES_DEFAULTS. Even
FILL_PROPERTIES is not needed for all cases. aFullPropertyMap_Impl is used in a
more common sense (as the name implies, too), so I would not hesitate to just
add the needed properties like the already added ones. It may be nice to have
extra property sets here for different shape types, but seems not necessary.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
--- Comment #9 from Ma Bingbing <ji...@gmail.com> ---
It is all right, thanks for your patch
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
Ma Bingbing <ji...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jiazema@gmail.com
--- Comment #2 from Ma Bingbing <ji...@gmail.com> ---
Root cause:
1. In style.xml of the sample file, there is a "default" cell style, which
applied on the table. In this style, we can see the border properties
"fo:border..." in <style:paragraph-properties.../>. So the borders exist in the
xml file.
2. When set one property, should check whether it is in the propertySet in
stlsheet.cxx (GetStylePropertySet line 82). But the border properties aren't in
the propertySet. Then we can't set the value read/write from/to style.xml
Solution:
add border properties to propertySet for cell style.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
Li Feng Wang <ph...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |phoenix.wanglf@gmail.com
--- Comment #12 from Li Feng Wang <ph...@gmail.com> ---
Verified pass on build 1397404.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
Shenfeng Liu <li...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |liushenf@gmail.com
Target Milestone|--- |AOO 3.5.0
--- Comment #13 from Shenfeng Liu <li...@gmail.com> ---
Update Target Milestone to AOO 3.5.0.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
--- Comment #10 from SVN Robot <sv...@dev.null.org> ---
"alg" committed SVN revision 1387874 into trunk:
#120885# Added missing properties for table border to property set to
process...
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
--- Comment #5 from Armin Le Grand <Ar...@me.com> ---
Created attachment 79528
--> https://issues.apache.org/ooo/attachment.cgi?id=79528&action=edit
Patc
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |Armin.Le.Grand@me.com
--- Comment #4 from Armin Le Grand <Ar...@me.com> ---
ALG: One question: Why not add the border properties directly to
aFullPropertyMap_Impl and to potentially always have them? It's already done
for e.g. SPECIAL_DIMENSIONING_PROPERTIES_DEFAULTS and should do no harm.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79528|0 |1
is patch| |
Attachment #79528|Patc |Patch to just add the
description| |border attributes to the
| |standard property set
--- Comment #6 from Armin Le Grand <Ar...@me.com> ---
Comment on attachment 79528
--> https://issues.apache.org/ooo/attachment.cgi?id=79528
Patch to just add the border attributes to the standard property set
ALG: Proposed patch which just adds the missing attributes to the common
property set so that they can be preserved
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
--- Comment #1 from Ma Bingbing <ji...@gmail.com> ---
Created attachment 79484
--> https://issues.apache.org/ooo/attachment.cgi?id=79484&action=edit
sample file
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
Li Feng Wang <ph...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|VERIFIED |CLOSED
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
Armin Le Grand <Ar...@me.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #11 from Armin Le Grand <Ar...@me.com> ---
ALG: Okay, committed, done.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 120885] [From Symphony]Sample file's table border is missing
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=120885
Ma Bingbing <ji...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #79485| |review?
Flags| |
--- Comment #3 from Ma Bingbing <ji...@gmail.com> ---
Created attachment 79485
--> https://issues.apache.org/ooo/attachment.cgi?id=79485&action=edit
Fix patch for this issue
--
You are receiving this mail because:
You are the assignee for the bug.