[GitHub] [tomcat] fmarco76 commented on pull request #639: Cusotm ssl engine parameters

["fmarco76 (via GitHub)" <gi...@apache.org>]

fmarco76 commented on PR #639:
URL: https://github.com/apache/tomcat/pull/639#issuecomment-1639759214

   > The only thing that caught my eye was that the signature of `AbstractNetworkChannelEndpoint.createChannel` has changed by widening the return value from `NetworkChannel` to `Channel`. This change is not backward compatible and we might want to introduce a new method instead of changing the signature of the current one.
   
   Hi @ChristopherSchultz, the `AbstractNetworkChannelEndpoint.createChannel` is introduced by this PR so I am not sure this is widening the return value. Currently, the channel is created inside the method `NioEndpoint.setSocketOptions` and does not invokes other methods. I have introduced the `createChannel` so I can override  it in a subclass  and associate a different channel keeping the endpoint logic.
   
   The only problem with back-porting I can think of it is that classes extending the `AbstractNetworkChannelEndpoint` will need to implement this method. To avoid this I can convert to a concrete method which throw an exception when invoked. In this way classes not using it will still work and the other have to override it.  
   Would this change make it  good for back-porting or should I look at different approaches. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org