You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/03 00:44:54 UTC
[GitHub] [geode] dschneider-pivotal opened a new pull request #5204: GEODE-8158: enhance LocalHostUtil to support anyLocalAddress
dschneider-pivotal opened a new pull request #5204:
URL: https://github.com/apache/geode/pull/5204
Changed redis to have its default bind address to be anyLocalAddress instead of a single local address.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #5204: GEODE-8158: enhance LocalHostUtil to support anyLocalAddress
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on pull request #5204:
URL: https://github.com/apache/geode/pull/5204#issuecomment-638421929
The UpgradeTestOpenJDK11 failure is not related to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5204: GEODE-8158: enhance LocalHostUtil to support anyLocalAddress
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5204:
URL: https://github.com/apache/geode/pull/5204#discussion_r434573456
##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -56,6 +57,7 @@ public void shutdownActuallyShutsDownTheServer() {
}
@Test
+ @Ignore("this test is flaky")
Review comment:
Should we create a Jira for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5204: GEODE-8158: enhance LocalHostUtil to support anyLocalAddress
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5204:
URL: https://github.com/apache/geode/pull/5204#discussion_r434675268
##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -56,6 +57,7 @@ public void shutdownActuallyShutsDownTheServer() {
}
@Test
+ @Ignore("this test is flaky")
Review comment:
I think I figured out why this test was still flaky. I removed this ignore and added a fix for the flakiness in: https://github.com/apache/geode/pull/5204/commits/823cf5a5c09002e4e543a48ac3a0c7b70232dcc9
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on pull request #5204: GEODE-8158: enhance LocalHostUtil to support anyLocalAddress
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on pull request #5204:
URL: https://github.com/apache/geode/pull/5204#issuecomment-638467587
the acceptance test failures all had to do with docker not being available
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5204: GEODE-8158: enhance LocalHostUtil to support anyLocalAddress
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5204:
URL: https://github.com/apache/geode/pull/5204#discussion_r434735608
##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -56,6 +57,7 @@ public void shutdownActuallyShutsDownTheServer() {
}
@Test
+ @Ignore("this test is flaky")
Review comment:
Good find!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal merged pull request #5204: GEODE-8158: enhance LocalHostUtil to support anyLocalAddress
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged pull request #5204:
URL: https://github.com/apache/geode/pull/5204
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org