You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/12/12 08:04:17 UTC
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #4981: boards/arm/samv7: Introduce common folder and refactor MCUboot
pkarashchenko commented on a change in pull request #4981:
URL: https://github.com/apache/incubator-nuttx/pull/4981#discussion_r767234769
##########
File path: boards/arm/samv7/same70-qmtech/configs/mcuboot-loader/defconfig
##########
@@ -44,13 +46,11 @@ CONFIG_RAM_SIZE=262144
CONFIG_RAM_START=0x20400000
CONFIG_RAW_BINARY=y
CONFIG_RR_INTERVAL=200
-CONFIG_SAME70QMTECH_FORMAT_MCUBOOT=y
-CONFIG_SAME70QMTECH_MCUBOOT_BOOTLOADER=y
+CONFIG_SAMV7_FORMAT_MCUBOOT=y
Review comment:
```suggestion
CONFIG_SAMV7_FORMAT_MCUBOOT=y
CONFIG_SAMV7_MCUBOOT_BOOTLOADER=y
```
##########
File path: boards/arm/samv7/common/src/sam_progmem_common.c
##########
@@ -196,7 +184,7 @@ static int init_ota_partitions(void)
return ret;
}
-#endif
+#endif /* CONFIG_SAMV7_PROGMEM_MCUBOOT_PARTITION */
Review comment:
We need to stick to one of the names either `OTA_PARTITION` or `MCUBOOT_PARTITION`.
##########
File path: boards/arm/samv7/same70-xplained/README.txt
##########
@@ -1716,8 +1716,7 @@ Configuration sub-directories
CONFIG_MCUBOOT_BOOTLOADER=y
CONFIG_MCUBOOT_ENABLE_LOGGING=y
- CONFIG_SAME70XPLAINED_FORMAT_MCUBOOT=y
- CONFIG_SAME70XPLAINED_MCUBOOT_BOOTLOADER=y
+ CONFIG_SAMV7_FORMAT_MCUBOOT=y
Review comment:
```suggestion
CONFIG_SAMV7_FORMAT_MCUBOOT=y
CONFIG_SAMV7_MCUBOOT_BOOTLOADER=y
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org