You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@httpd.apache.org by Jacob Champion <ch...@gmail.com> on 2016/12/06 18:07:39 UTC

Is 2.2.x broken?

I'm trying to test a backport to the 2.2.x tip, but it looks like 
r1758671 might have busted our request parsing. Every test we have 
fails; I think ap_rgetline() is no longer dealing with the final CRLF 
line correctly. Reverting that commit fixes things.

Can anyone confirm that it's not just something on my end?

--Jacob

Re: Is 2.2.x broken?

Posted by Eric Covener <co...@gmail.com>.

The fix is the thing I just added to STATUS today

On Tue, Dec 6, 2016 at 1:07 PM, Jacob Champion <ch...@gmail.com> wrote:
> I'm trying to test a backport to the 2.2.x tip, but it looks like r1758671
> might have busted our request parsing. Every test we have fails; I think
> ap_rgetline() is no longer dealing with the final CRLF line correctly.
> Reverting that commit fixes things.
>
> Can anyone confirm that it's not just something on my end?
>
> --Jacob



-- 
Eric Covener
covener@gmail.com

Re: Is 2.2.x broken?

Posted by William A Rowe Jr <wr...@rowe-clan.net>.

An associated patch was likely overlooked, please go ahead and revert.


On Dec 6, 2016 12:07 PM, "Jacob Champion" <ch...@gmail.com> wrote:

> I'm trying to test a backport to the 2.2.x tip, but it looks like r1758671
> might have busted our request parsing. Every test we have fails; I think
> ap_rgetline() is no longer dealing with the final CRLF line correctly.
> Reverting that commit fixes things.
>
> Can anyone confirm that it's not just something on my end?
>
> --Jacob
>