[jira] [Commented] (KAFKA-6082) consider fencing zookeeper updates with controller epoch zkVersion

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-6082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495880#comment-16495880 ] 

ASF GitHub Bot commented on KAFKA-6082:
---------------------------------------

hzxa21 opened a new pull request #5101: KAFKA-6082: Fence zookeeper updates with controller epoch zkVersion
URL: https://github.com/apache/kafka/pull/5101
 
 
   This PR aims to enforce the controller can only update zookeeper states after checking the controller epoch zkVersion. The check and zookeeper state updates are wrapped in the zookeeper multi() operations to ensure that they are done atomically. This PR is necessary to resolve issues related to multiple controllers (i.e. old controller updates zookeeper states before resignation, which is possible during controller failover based on the single threaded event queue model we have)
   
   This PR includes the following changes:
   - Add MultiOp request and response in ZookeeperClient
   - Ensure all zookeeper updates done by controller are protected by checking the current controller epoch zkVersion
   - Modify test cases in KafkaZkClientTest to test mismatch controller epoch zkVersion
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> consider fencing zookeeper updates with controller epoch zkVersion
> ------------------------------------------------------------------
>
>                 Key: KAFKA-6082
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6082
>             Project: Kafka
>          Issue Type: Sub-task
>            Reporter: Onur Karaman
>            Priority: Major
>
> If we want, we can use multi-op to fence zookeeper updates with the controller epoch's zkVersion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)