You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/03/17 21:50:35 UTC
Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-1168
https://issues.apache.org/jira/browse/AURORA-1168
Repository: aurora
Description
-------
Change "update list" subcommand to accept a hierarchy.
Diffs
-----
src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76807
-----------------------------------------------------------
Master (4b39d26) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
src.test.python.apache.aurora.client.base ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.client ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.context ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... FAILURE
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 17, 2015, 8:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 8:50 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change "update list" subcommand to accept a hierarchy.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
> On March 17, 2015, 11:36 p.m., Aurora ReviewBot wrote:
> > Master (a419863) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.collections-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for twitter.common.util
> > Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
> > Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
> > Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.util-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for twitter.common.log
> > Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
> > Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
> > Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.log-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for twitter.common.process
> > Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
> > Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
> > Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.process-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for gitdb
> > building 'gitdb._perf' extension
> > x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c gitdb/_fun.c -o build/temp.linux-x86_64-2.7/gitdb/_fun.o
> > x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c gitdb/_delta_apply.c -o build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o
> > x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -D_FORTIFY_SOURCE=2 -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/gitdb/_fun.o build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o -o build/lib.linux-x86_64-2.7/gitdb/_perf.so
> > Running setup.py install for twitter.common.app
> > Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
> > Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
> > Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.app-0.3.0-py2.7-nspkg.pth
> > Running setup.py install for GitPython
> > /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/setuptools/dist.py:292: UserWarning: The version specified ('0.3.2 RC1') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
> > "details." % self.metadata.version
> > Running setup.py install for pep8
> > Installing pep8 script to /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
> > Running setup.py install for pyflakes
> > Installing pyflakes script to /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
> > Running setup.py install for twitter.checkstyle
> > Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
> > Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.checkstyle-0.1.0-py2.7-nspkg.pth
> > Installing twitterstyle script to /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
> > Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0 twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 twitter.common.options-0.3.0 twitter.common.process-0.3.0 twitter.common.string-0.3.0 twitter.common.util-0.3.0
> > F841:ERROR src/main/python/apache/aurora/client/cli/update.py:316 local variable 'created' is assigned to but never used
> > | created = summary.state.createdTimestampMs
> >
> > F841:ERROR src/main/python/apache/aurora/client/cli/update.py:317 local variable 'lastMod' is assigned to but never used
> > | lastMod = summary.state.lastModifiedTimestampMs
> >
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Doh sorry for the noise. Fixing.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76845
-----------------------------------------------------------
On March 17, 2015, 11:30 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 11:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76845
-----------------------------------------------------------
Master (a419863) is red with this patch.
./build-support/jenkins/build.sh
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.collections-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.util
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.util-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.log
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.log-0.3.0-py2.7-nspkg.pth
Running setup.py install for twitter.common.process
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.process-0.3.0-py2.7-nspkg.pth
Running setup.py install for gitdb
building 'gitdb._perf' extension
x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c gitdb/_fun.c -o build/temp.linux-x86_64-2.7/gitdb/_fun.o
x86_64-linux-gnu-gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -Igitdb -I/usr/include/python2.7 -c gitdb/_delta_apply.c -o build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o
x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -D_FORTIFY_SOURCE=2 -g -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/gitdb/_fun.o build/temp.linux-x86_64-2.7/gitdb/_delta_apply.o -o build/lib.linux-x86_64-2.7/gitdb/_perf.so
Running setup.py install for twitter.common.app
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/common/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.common.app-0.3.0-py2.7-nspkg.pth
Running setup.py install for GitPython
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/local/lib/python2.7/site-packages/setuptools/dist.py:292: UserWarning: The version specified ('0.3.2 RC1') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
"details." % self.metadata.version
Running setup.py install for pep8
Installing pep8 script to /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for pyflakes
Installing pyflakes script to /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Running setup.py install for twitter.checkstyle
Skipping installation of /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter/__init__.py (namespace package)
Installing /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/lib/python2.7/site-packages/twitter.checkstyle-0.1.0-py2.7-nspkg.pth
Installing twitterstyle script to /home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/checkstyle.venv/bin
Successfully installed GitPython-0.3.2rc1 gitdb-0.6.4 pep8-1.4.5 pyflakes-0.7.2 smmap-0.9.0 twitter.checkstyle-0.1.0 twitter.common.app-0.3.0 twitter.common.collections-0.3.0 twitter.common.contextutil-0.3.0 twitter.common.dirutil-0.3.0 twitter.common.lang-0.3.0 twitter.common.log-0.3.0 twitter.common.options-0.3.0 twitter.common.process-0.3.0 twitter.common.string-0.3.0 twitter.common.util-0.3.0
F841:ERROR src/main/python/apache/aurora/client/cli/update.py:316 local variable 'created' is assigned to but never used
| created = summary.state.createdTimestampMs
F841:ERROR src/main/python/apache/aurora/client/cli/update.py:317 local variable 'lastMod' is assigned to but never used
| lastMod = summary.state.lastModifiedTimestampMs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 17, 2015, 11:30 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 11:30 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
> On March 18, 2015, 12:03 a.m., David McLaughlin wrote:
> > src/test/python/apache/aurora/client/cli/test_supdate.py, line 408
> > <https://reviews.apache.org/r/32171/diff/2/?file=898419#file898419line408>
> >
> > This is more of a general concern, but it would be nice to avoid adding new tests in this style - and instead test the Command instance directly. I can't find the actual back and forth that led me to testing like this, but it was introduced here: https://reviews.apache.org/r/27848/diff/#
Nearly forgot to address this. Patch incoming that moves all test cases for this command to the new style.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76853
-----------------------------------------------------------
On March 19, 2015, 8:22 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 8:22 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76853
-----------------------------------------------------------
src/test/python/apache/aurora/client/cli/test_supdate.py
<https://reviews.apache.org/r/32171/#comment124531>
This is more of a general concern, but it would be nice to avoid adding new tests in this style - and instead test the Command instance directly. I can't find the actual back and forth that led me to testing like this, but it was introduced here: https://reviews.apache.org/r/27848/diff/#
- David McLaughlin
On March 17, 2015, 11:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 11:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77137
-----------------------------------------------------------
@ReviewBot retry
I think i may have outpaced the bot here, the last reply seems for a stale diff.
- Bill Farner
On March 19, 2015, 10:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 10:27 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77144
-----------------------------------------------------------
Ship it!
Master (465086e) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 20, 2015, 12:29 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 20, 2015, 12:29 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/
-----------------------------------------------------------
(Updated March 20, 2015, 12:29 a.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-1168
https://issues.apache.org/jira/browse/AURORA-1168
Repository: aurora
Description
-------
NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
I'm open to input on this.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77125
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On March 19, 2015, 10:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 10:27 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77141
-----------------------------------------------------------
Master (465086e) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
src.test.python.apache.aurora.client.base ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.client ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.context ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... FAILURE
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 19, 2015, 10:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 10:27 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77124
-----------------------------------------------------------
Master (6396410) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
src.test.python.apache.aurora.client.base ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.client ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.context ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... FAILURE
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 19, 2015, 10:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 10:27 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77138
-----------------------------------------------------------
Master (6396410) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.api.updater_util ..... SUCCESS
src.test.python.apache.aurora.client.base ..... SUCCESS
src.test.python.apache.aurora.client.binding_helper ..... SUCCESS
src.test.python.apache.aurora.client.cli.api ..... SUCCESS
src.test.python.apache.aurora.client.cli.client ..... SUCCESS
src.test.python.apache.aurora.client.cli.command_hooks ..... SUCCESS
src.test.python.apache.aurora.client.cli.config ..... SUCCESS
src.test.python.apache.aurora.client.cli.context ..... SUCCESS
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... FAILURE
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 19, 2015, 10:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 10:27 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77140
-----------------------------------------------------------
@ReviewBot retry
Forgive me for generating noise, i'm trying to figure out what test case is failing...not seeing this locally. I wasn't able to find the previous run in the bot's build history.
- Bill Farner
On March 19, 2015, 10:27 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 10:27 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/
-----------------------------------------------------------
(Updated March 19, 2015, 10:27 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-1168
https://issues.apache.org/jira/browse/AURORA-1168
Repository: aurora
Description
-------
NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
I'm open to input on this.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
> On March 19, 2015, 9:13 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 250
> > <https://reviews.apache.org/r/32171/diff/4/?file=900349#file900349line250>
> >
> > How about a special "blocked" group to display only the updates blocked due to lack of heartbeat? Could be quite useful for monitoring of blocked updates.
Done.
> On March 19, 2015, 9:13 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 258
> > <https://reviews.apache.org/r/32171/diff/4/?file=900349#file900349line258>
> >
> > Move to previous line?
Done.
> On March 19, 2015, 9:13 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 272
> > <https://reviews.apache.org/r/32171/diff/4/?file=900349#file900349line272>
> >
> > Recommend adding a phrase explaining the behavior in case multiple groups/statuses are specified.
Done.
> On March 19, 2015, 9:13 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 314
> > <https://reviews.apache.org/r/32171/diff/4/?file=900349#file900349line314>
> >
> > While it's converted to set by thrift anyway, I'd still recommend using a set() here to explicitly assert no duplicates are ever accepted.
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77102
-----------------------------------------------------------
On March 19, 2015, 9:09 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 9:09 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77102
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124993>
How about a special "blocked" group to display only the updates blocked due to lack of heartbeat? Could be quite useful for monitoring of blocked updates.
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124992>
Move to previous line?
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124997>
Recommend adding a phrase explaining the behavior in case multiple groups/statuses are specified.
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124999>
While it's converted to set by thrift anyway, I'd still recommend using a set() here to explicitly assert no duplicates are ever accepted.
- Maxim Khutornenko
On March 19, 2015, 9:09 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 9:09 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77107
-----------------------------------------------------------
Master (6396410) is red with this patch.
./build-support/jenkins/build.sh
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_task.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_quota.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_command_hooks.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_cancel_update.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_config_noun.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_create.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_kill.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_status.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_diff.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_inspect.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_update.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_plugins.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_restart.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_cron.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_client.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/__init__.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_api_from_cli.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/util.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_version.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_open.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/cli/test_context.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/hooks/test_hooked_api.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_sla.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_api.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_health_check.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_job_monitor.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_updater_util.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_scheduler_mux.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_scheduler_client.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_quota_check.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_instance_watcher.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_updater.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_task_util.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/__init__.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/client/api/test_restarter.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/test_thrift.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/test_base.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/test_loader.py Everything Looks Good!
SUCCESS: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/python/apache/aurora/config/test_constraint_parsing.py Everything Looks Good!
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 19, 2015, 9:09 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 9:09 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/
-----------------------------------------------------------
(Updated March 19, 2015, 9:09 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-1168
https://issues.apache.org/jira/browse/AURORA-1168
Repository: aurora
Description
-------
NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
I'm open to input on this.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review77101
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 19, 2015, 1:22 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 19, 2015, 1:22 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/
-----------------------------------------------------------
(Updated March 19, 2015, 8:22 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Changes
-------
This diff reverts to showing the same data that was there previously, in columns instead of multiple lines.
It also addresses a comment by Maxim, to allow filtering by raw status values (in addition to the shorthand values like 'active', added in this patch).
Finally, i am displaying the timestamps as ISO 8601 (they were previously raw timestamp millis).
Bugs: AURORA-1168
https://issues.apache.org/jira/browse/AURORA-1168
Repository: aurora
Description
-------
NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
I'm open to input on this.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76855
-----------------------------------------------------------
Master (a419863) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
src.test.python.apache.thermos.cli.commands.commands ..... SUCCESS
src.test.python.apache.thermos.cli.common ..... SUCCESS
src.test.python.apache.thermos.cli.main ..... SUCCESS
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 17, 2015, 11:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 11:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On March 18, 2015, 12:04 a.m., Kevin Sweeney wrote:
> > src/test/python/apache/aurora/client/cli/test_supdate.py, lines 404-406
> > <https://reviews.apache.org/r/32171/diff/3/?file=898440#file898440line404>
> >
> > How would you feel about including all of the currently available data with a header row?
> >
> > Also instead of raw epoch time how about ISO 8601 - using the spaceless 'T' form (`2015-03-15T13:27:36+00:00`)
> How would you feel about including all of the currently available data with a header row?
-1 on shoving all available data into a single header row. I'd rather see a clean output here and rely on `aurora update info` for drill downs.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76854
-----------------------------------------------------------
On March 17, 2015, 11:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 11:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76854
-----------------------------------------------------------
src/test/python/apache/aurora/client/cli/test_supdate.py
<https://reviews.apache.org/r/32171/#comment124532>
How would you feel about including all of the currently available data with a header row?
Also instead of raw epoch time how about ISO 8601 - using the spaceless 'T' form (`2015-03-15T13:27:36+00:00`)
- Kevin Sweeney
On March 17, 2015, 4:54 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 4:54 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
>
> I'm open to input on this.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/
-----------------------------------------------------------
(Updated March 17, 2015, 11:54 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-1168
https://issues.apache.org/jira/browse/AURORA-1168
Repository: aurora
Description
-------
NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
I'm open to input on this.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/
-----------------------------------------------------------
(Updated March 17, 2015, 11:30 p.m.)
Review request for Aurora, David McLaughlin and Zameer Manji.
Bugs: AURORA-1168
https://issues.apache.org/jira/browse/AURORA-1168
Repository: aurora
Description (updated)
-------
NOTE: I also am proposing with this change that the output format of `aurora update list` be line-oriented and more concise (see test changes for examples). The idea is to follow up ~immediately with AURORA-1206. The proposal is for this command to let you retrieve update identifiers, and `update status` (whose name may change) will allow you to drill into updates.
I'm open to input on this.
Diffs (updated)
-----
src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
Diff: https://reviews.apache.org/r/32171/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
> On March 17, 2015, 10:59 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 267
> > <https://reviews.apache.org/r/32171/diff/1/?file=898128#file898128line267>
> >
> > How about adding all statuses here to allow searching by a specific job update status in addition to a group?
I considered that, but it makes for some pretty heinous help output. I don't feel too strongly either way, but i'm currently of the mindset that we can add it later without breaking compatibility.
> On March 17, 2015, 10:59 p.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 269
> > <https://reviews.apache.org/r/32171/diff/1/?file=898128#file898128line269>
> >
> > typo
Fixed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76836
-----------------------------------------------------------
On March 17, 2015, 8:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 8:50 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change "update list" subcommand to accept a hierarchy.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76836
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124508>
How about adding all statuses here to allow searching by a specific job update status in addition to a group?
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124503>
typo
- Maxim Khutornenko
On March 17, 2015, 8:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 8:50 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change "update list" subcommand to accept a hierarchy.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Bill Farner <wf...@apache.org>.
> On March 17, 2015, 10:46 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 226
> > <https://reviews.apache.org/r/32171/diff/1/?file=898128#file898128line226>
> >
> > This is a duplicate of the 'PartialJobKey' class in client/cli/jobs.py. Please consider reusing that class to prevent duplication.
> >
> > Ideally you do this so your 'update_filter' function can be reused for parsing these CLI values.
I initially looked into sharing code, but the use cases are different. For example, `PartialJobkey` and relevant code supports wildcards, which i do not wish to support here. Given that the behavior was different, i did not feel that sharing the one-liner for the namedtuple was constructive.
[1] https://github.com/apache/incubator-aurora/blob/2f991069e60e47ddbbaf1d60d6403922bbb0e208/src/main/python/apache/aurora/client/cli/jobs.py#L68-L87
> On March 17, 2015, 10:46 p.m., Zameer Manji wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 281
> > <https://reviews.apache.org/r/32171/diff/1/?file=898128#file898128line281>
> >
> > No need for .dedent here.
Removed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76832
-----------------------------------------------------------
On March 17, 2015, 8:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 8:50 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change "update list" subcommand to accept a hierarchy.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76832
-----------------------------------------------------------
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124498>
This is a duplicate of the 'PartialJobKey' class in client/cli/jobs.py. Please consider reusing that class to prevent duplication.
Ideally you do this so your 'update_filter' function can be reused for parsing these CLI values.
src/main/python/apache/aurora/client/cli/update.py
<https://reviews.apache.org/r/32171/#comment124499>
No need for .dedent here.
- Zameer Manji
On March 17, 2015, 1:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 1:50 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change "update list" subcommand to accept a hierarchy.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 32171: Change "update list" subcommand to accept a
hierarchy.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32171/#review76844
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 17, 2015, 1:50 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32171/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 1:50 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Zameer Manji.
>
>
> Bugs: AURORA-1168
> https://issues.apache.org/jira/browse/AURORA-1168
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Change "update list" subcommand to accept a hierarchy.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/cli/update.py f025d46d50592156e2455313890e981722ab63a5
> src/test/python/apache/aurora/client/cli/test_supdate.py cb66439a778349fc5add4985a7395655c9e1328a
>
> Diff: https://reviews.apache.org/r/32171/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>