[GitHub] [carbondata] QiangCai commented on a change in pull request #4199: [CARBONDATA-4271] Support DPP for carbon

[GitBox <gi...@apache.org>]

QiangCai commented on a change in pull request #4199:
URL: https://github.com/apache/carbondata/pull/4199#discussion_r692701424



##########
File path: integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/dblocation/DBLocationCarbonTableTestCase.scala
##########
@@ -268,7 +268,7 @@ class DBLocationCarbonTableTestCase extends QueryTest with BeforeAndAfterEach {
   }
 
   test("Alter table drop column test") {
-    sql(s"create database carbon location '$dbLocation'")
+    sql(s"create database carbon location '$dbLocation + /newdb/'")

Review comment:
       no need +

##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonInsertIntoHadoopFsRelationCommand.scala
##########
@@ -199,7 +199,7 @@ case class CarbonInsertIntoHadoopFsRelationCommand(
       // refresh cached files in FileIndex
       fileIndex.foreach(_.refresh())
       // refresh data cache if table is cached
-      sparkSession.catalog.refreshByPath(outputPath.toString)
+      // sparkSession.catalog.refreshByPath(outputPath.toString)

Review comment:
       1. why commented it?
   2. if no need already, remove it directly.

##########
File path: integration/spark/src/main/scala/org/apache/spark/sql/execution/strategy/CarbonDataSourceScan.scala
##########
@@ -49,9 +50,19 @@ case class CarbonDataSourceScan(
     directScanSupport: Boolean,
     @transient extraRDD: Option[(RDD[InternalRow], Boolean)] = None,
     tableIdentifier: Option[TableIdentifier] = None,
+    @transient selectedCatalogPartitions : Seq[CatalogTablePartition] = Seq.empty,
+    @transient partitions: Seq[SparkExpression],

Review comment:
       what are the different points between "partitionFilters" and "partitions"?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org